Skip to content

Commit

Permalink
Add lenient strictness to k8s test (#5598)
Browse files Browse the repository at this point in the history
Motivation:

We're seeing the following error and I don't think there's much we can
do about it.
I propose that we just adjust the lenient setting - the original purpose
of mockito strictness is probably not relevant here since we use a 3rd
party's test anyways.

https://ge.armeria.dev/scans/tests?search.relativeStartTime=P28D&search.tags=CI%2Cnot:PR&search.timeZoneId=Asia%2FSeoul&tests.container=com.linecorp.armeria.client.kubernetes.ArmeriaHttpHttpLoggingInterceptorTest&tests.sortField=FLAKY&tests.test=responseBodyIsNotConsumed()

<!--
Visit this URL to learn more about how to write a pull request
description:

https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
  • Loading branch information
jrhee17 authored Apr 12, 2024
1 parent c5447c2 commit c49de7a
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,17 @@
import java.lang.reflect.Field;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;

import io.fabric8.kubernetes.client.http.AbstractHttpLoggingInterceptorTest;
import io.fabric8.kubernetes.client.http.HttpClient;

@SuppressWarnings("JUnitTestCaseWithNoTests")
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
class ArmeriaHttpHttpLoggingInterceptorTest extends AbstractHttpLoggingInterceptorTest {

@AfterEach
Expand Down

0 comments on commit c49de7a

Please sign in to comment.