Address comments from @ikhoon

line · Feb 15, 2024 · 7bba312 · 7bba312
1 parent 584e37a
commit 7bba312
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/xds/src/main/java/com/linecorp/armeria/xds/BootstrapListeners.java b/xds/src/main/java/com/linecorp/armeria/xds/BootstrapListeners.java
@@ -18,7 +18,6 @@
 import java.util.Map;
 
 import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.ImmutableMap.Builder;
 
 import io.envoyproxy.envoy.config.bootstrap.v3.Bootstrap;
 import io.envoyproxy.envoy.config.bootstrap.v3.Bootstrap.StaticResources;
@@ -29,7 +28,7 @@ final class BootstrapListeners {
     private final Map<String, ListenerXdsResource> listeners;
 
     BootstrapListeners(Bootstrap bootstrap) {
-        final Builder<String, ListenerXdsResource> builder = ImmutableMap.builder();
+        final ImmutableMap.Builder<String, ListenerXdsResource> builder = ImmutableMap.builder();
         if (bootstrap.hasStaticResources()) {
             final StaticResources staticResources = bootstrap.getStaticResources();
             for (Listener listener: staticResources.getListenersList()) {

diff --git a/xds/src/main/java/com/linecorp/armeria/xds/XdsConverterUtil.java b/xds/src/main/java/com/linecorp/armeria/xds/XdsConverterUtil.java
@@ -48,7 +48,7 @@ static List<Endpoint> convertEndpoints(ClusterLoadAssignment clusterLoadAssignme
     }
 
     static List<Endpoint> convertEndpoints(ClusterLoadAssignment clusterLoadAssignment, Struct filterMetadata) {
-        checkArgument(filterMetadata.getFieldsCount() != 0,
+        checkArgument(filterMetadata.getFieldsCount() > 0,
                       "filterMetadata.getFieldsCount(): %s (expected: > 0)", filterMetadata.getFieldsCount());
         final Predicate<LbEndpoint> lbEndpointPredicate = lbEndpoint -> {
             final Struct endpointMetadata = lbEndpoint.getMetadata().getFilterMetadataOrDefault(