Tw 784/improve play video #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/969 |
hoangdat
reviewed
Nov 14, 2023
hoangdat
reviewed
Nov 14, 2023
|
I can't close dialog while loading video on WEB |
Done, Screen.Recording.2023-11-15.at.10.54.13.mov |
sherlockvn
force-pushed
the
TW-784/improve-play-video
branch
from
f7fc98c to
a427299
Compare
nqhhdev
reviewed
Nov 15, 2023
nqhhdev
reviewed
Nov 15, 2023
nqhhdev
reviewed
Nov 15, 2023
drminh2807
approved these changes
Nov 16, 2023
nqhhdev
approved these changes
Nov 16, 2023
hoangdat
approved these changes
Nov 17, 2023
sherlockvn
force-pushed
the
TW-784/improve-play-video
branch
from
f989d0e to
35c1ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo Web
Screen.Recording.2023-11-14.at.15.12.10.mov
Demo mobile:
demoiphone.MP4
Demo android:
Screen.Recording.2023-11-14.at.15.48.45.mov