Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-893: Remove pill on mentionned users #927

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

imGok
Copy link
Contributor

@imGok imGok commented Nov 7, 2023

  • New mentionned pill in text message (blue text)
  • Matrix ID in suggestion panel

image
image
image

Case tested :

  • long display name
  • tag with message
  • tag with message for long long display name
  • tag with message for long long display name with line break in display name
  • tag with very short display name
  • tag with icon inside name
Android.Emulator.-.Resizable_Experimental_API_33_5554.2023-11-10.15-02-33.mp4
Twake.Chat.-.Google.Chrome.2023-11-13.15-12-19.mp4

#893

Copy link

github-actions bot commented Nov 7, 2023

This PR has been deployed to https://linagora.github.io/twake-on-matrix/927

@nqhhdev
Copy link
Member

nqhhdev commented Nov 8, 2023

Pls demo case tag in input bar

Screenshot 2023-11-08 at 08 35 41

lib/widgets/pill.dart Outdated Show resolved Hide resolved
@hoangdat
Copy link
Member

hoangdat commented Nov 8, 2023

Pls demo case tag in input bar

Screenshot 2023-11-08 at 08 35 41

I prefer to keep the performance for composer than make it like the design for this case. Please consider it carefully

@imGok imGok changed the title TW-893: Remove pill on mentionned users WIP TW-893: Remove pill on mentionned users Nov 9, 2023
@imGok imGok force-pushed the TW-893-suggestions-and-pills branch from 9b382d8 to 240f3bb Compare November 10, 2023 09:24
@imGok imGok force-pushed the TW-893-suggestions-and-pills branch from 240f3bb to ff2566d Compare November 10, 2023 09:27
@imGok imGok force-pushed the TW-893-suggestions-and-pills branch from 135d342 to 1b10867 Compare November 10, 2023 10:05
@imGok imGok changed the title WIP TW-893: Remove pill on mentionned users TW-893: Remove pill on mentionned users Nov 10, 2023
lib/widgets/mentionned_user.dart Outdated Show resolved Hide resolved
lib/pages/chat/input_bar/input_bar.dart Outdated Show resolved Hide resolved
lib/pages/chat/input_bar/input_bar.dart Show resolved Hide resolved
@hoangdat
Copy link
Member

for this case:
image
what happens when user try to click on tag?

@hoangdat
Copy link
Member

Please add and the case @[Hoang D 👍]

@imGok
Copy link
Contributor Author

imGok commented Nov 13, 2023

for this case: image what happens when user try to click on tag?

it opens the user details (web demo video)
image

@imGok imGok force-pushed the TW-893-suggestions-and-pills branch from 044c87d to 45c91df Compare November 13, 2023 14:24
@imGok
Copy link
Contributor Author

imGok commented Nov 13, 2023

@hoangdat

image

Twake.Chat.-.Google.Chrome.2023-11-13.18-30-58.mp4

@hoangdat hoangdat merged commit f28b574 into main Nov 14, 2023
3 checks passed
@hoangdat hoangdat deleted the TW-893-suggestions-and-pills branch November 14, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants