Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-800 Apply new Search inside Chat design #856

Merged
merged 6 commits into from
Oct 31, 2023
Merged

TW-800 Apply new Search inside Chat design #856

merged 6 commits into from
Oct 31, 2023

Conversation

drminh2807
Copy link
Contributor

@drminh2807 drminh2807 commented Oct 25, 2023 •
edited
Loading

Issue

Demo

Screenshot 2023-10-25 at 14 55 59

2.mov
RPReplay_Final1698220986.MP4

Applied design

Screen.Recording.2023-10-26.at.11.11.51.mov

Empty view

Screen.Recording.2023-10-26.at.11.09.13.mov

@drminh2807 drminh2807 temporarily deployed to PR-856 October 25, 2023 08:18 — with GitHub Actions Inactive
@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/856

@hoangdat
Copy link
Member

style is not the same with design

image

@drminh2807 drminh2807 temporarily deployed to PR-856 October 26, 2023 04:16 — with GitHub Actions Inactive
@drminh2807 drminh2807 temporarily deployed to PR-856 October 26, 2023 04:34 — with GitHub Actions Inactive
hoangdat
hoangdat reviewed Oct 26, 2023
View reviewed changes
lib/pages/chat/chat.dart Outdated Show resolved Hide resolved
hoangdat
hoangdat reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix toggle problem:

  • open search by icon in app bar
  • click to open chat info
  • click on search icon in chat info
  • issue: search is close -> expect: search still open

@drminh2807
Copy link
Contributor Author

fix toggle problem:

  • open search by icon in app bar
  • click to open chat info
  • click on search icon in chat info
  • issue: search is close -> expect: search still open

done

@drminh2807 drminh2807 temporarily deployed to PR-856 October 27, 2023 04:21 — with GitHub Actions Inactive
hoangdat
hoangdat previously approved these changes Oct 27, 2023
View reviewed changes
@drminh2807 drminh2807 force-pushed the feat/new-search-part-2-complete branch 2 times, most recently from b82f119 to 0fbe294 Compare October 27, 2023 09:07
@drminh2807 drminh2807 changed the base branch from feat/new-search to main October 27, 2023 09:18
@drminh2807 drminh2807 dismissed hoangdat’s stale review October 27, 2023 09:18

The base branch was changed.

@drminh2807 drminh2807 force-pushed the feat/new-search-part-2-complete branch from 0fbe294 to 5817f0a Compare October 27, 2023 10:10
@drminh2807 drminh2807 temporarily deployed to PR-856 October 27, 2023 10:10 — with GitHub Actions Inactive
@drminh2807 drminh2807 force-pushed the feat/new-search-part-2-complete branch from 5817f0a to af0f0e2 Compare October 30, 2023 07:31
@drminh2807 drminh2807 temporarily deployed to PR-856 October 30, 2023 07:31 — with GitHub Actions Inactive
@drminh2807 drminh2807 force-pushed the feat/new-search-part-2-complete branch from af0f0e2 to dff53ec Compare October 30, 2023 09:01
@drminh2807 drminh2807 temporarily deployed to PR-856 October 30, 2023 09:01 — with GitHub Actions Inactive
@sherlockvn
Copy link
Collaborator

  • i think maybe change the empty view is like search in contacts, instead of 404. wdyt? @hoangdat
  • Can you check again with responsive web @drminh2807

@drminh2807 drminh2807 force-pushed the feat/new-search-part-2-complete branch from dff53ec to f0e5258 Compare October 31, 2023 02:50
@hoangdat hoangdat merged commit 0f82700 into main Oct 31, 2023
3 checks passed
@hoangdat hoangdat deleted the feat/new-search-part-2-complete branch October 31, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imGok imGok imGok left review comments

@nqhhdev nqhhdev nqhhdev approved these changes

@sherlockvn sherlockvn sherlockvn approved these changes

@hoangdat hoangdat hoangdat left review comments

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drminh2807 @hoangdat @sherlockvn @imGok @nqhhdev