Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP TW-849: select text in message bubble web #855

Closed
wants to merge 2 commits into from

Conversation

imGok
Copy link
Contributor

@imGok imGok commented Oct 24, 2023

Remove select on tap on web and long press

#849

issues:

  • Selectable texts in flutter web is not working wel and interfers with other gestures like dropzone buttons etc.
  • sometimes I cannot select text even if I use SelectableText, SelectionArea, SelectableRegion none of them works (for cleanrichtext especially)
  • sometimes I activate the drag & drop feature even If I have nothing selected
  • selection features such as double tap to select etc doesn't work in Flutter web, it's not like HTML
  • selection works well with simple text such as display name etc (SelectableText)

refs: https://api.flutter.dev/flutter/material/SelectionArea-class.html

@imGok imGok temporarily deployed to PR-855 October 24, 2023 17:44 — with GitHub Actions Inactive
@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/855

@imGok imGok changed the title TW-849: select text in message bubble web WIP TW-849: select text in message bubble web Oct 24, 2023
@sherlockvn
Copy link
Collaborator

Remove select on tap on web and long press

#849

issues:

  • Selectable texts in flutter web is not working wel and interfers with other gestures like dropzone buttons etc.
  • sometimes I cannot select text even if I use SelectableText, SelectionArea, SelectableRegion none of them works (for cleanrichtext especially)
  • sometimes I activate the drag & drop feature even If I have nothing selected
  • selection features such as double tap to select etc doesn't work in Flutter web, it's not like HTML
  • selection works well with simple text such as display name etc (SelectableText)

refs: https://api.flutter.dev/flutter/material/SelectionArea-class.html

I have checked the web again and found several issues:

  • When user tap to other places like composer, the selected text is blink.
  • The copy paste Ctrl+C and Ctrl+V is not working.

@imGok imGok closed this Nov 3, 2023
@hoangdat hoangdat deleted the TW-849-select-text-web branch November 13, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants