Tw 816/part 2 using navigator instead of page view #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
nqhhdev
reviewed
Oct 24, 2023
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/851 |
nqhhdev
reviewed
Oct 24, 2023
nqhhdev
reviewed
Oct 24, 2023
nqhhdev
reviewed
Oct 24, 2023
lib/widgets/layouts/adaptive_layout/adaptive_scaffold_view.dart
Outdated
Show resolved
Hide resolved
imGok
reviewed
Oct 24, 2023
imGok
reviewed
Oct 24, 2023
imGok
reviewed
Oct 24, 2023
imGok
reviewed
Oct 24, 2023
hoangdat
reviewed
Oct 24, 2023
hoangdat
reviewed
Oct 24, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
nqhhdev
reviewed
Oct 25, 2023
sherlockvn
force-pushed
the
TW-816/part-2-using-navigator-instead-of-page-view
branch
from
287bee1 to
865f6df
Compare
sherlockvn
force-pushed
the
TW-816/part-2-using-navigator-instead-of-page-view
branch
from
865f6df to
edbee28
Compare
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
hoangdat
reviewed
Oct 27, 2023
sherlockvn
force-pushed
the
TW-816/part-2-using-navigator-instead-of-page-view
branch
from
d9b9e70 to
54733c2
Compare
hoangdat
reviewed
Oct 30, 2023
hoangdat
approved these changes
Oct 30, 2023
sherlockvn
force-pushed
the
TW-816/part-2-using-navigator-instead-of-page-view
branch
from
b80b324 to
e6e8c57
Compare
drminh2807
approved these changes
Oct 30, 2023
hoangdat
deleted the
TW-816/part-2-using-navigator-instead-of-page-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
currently experiment Navigator inside the GoRouter,
so the PageView still keep the same, only new private chat, group chat and group chat info will using Navigator
Demo in tablet:
Screen.Recording.2023-10-29.at.23.23.56.mov
Demo web:
Screen.Recording.2023-10-24.at.12.03.46.mov
Demo mobile again:
Screen.Recording.2023-10-24.at.13.23.26.mov