TW-826: Improvement chat details #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/840 |
drminh2807
reviewed
Oct 19, 2023
lib/presentation/same_type_events_builder/same_type_events_list_builder.dart
Outdated
Show resolved
Hide resolved
imGok
reviewed
Oct 19, 2023
| key: const PageStorageKey("members"), | ||
| members: members ?? [], | ||
| actualMembersCount: actualMembersCount, | ||
| canRequestMoreMembers: members!.length < actualMembersCount, |
There was a problem hiding this comment.
if members is null => can't loadmore
imGok
reviewed
Oct 19, 2023
| valueListenable: controller.loadingMore, | ||
| builder: (context, loadingMore, child) => SliverToBoxAdapter( | ||
| child: | ||
| loadingMore ? const CenterLoadingIndicator() : const SizedBox(), |
There was a problem hiding this comment.
We use SizedBox(), SizedBox.shrink(), Container() in the application IMO we should be more consistent and choose one to make an empty widget.
There was a problem hiding this comment.
In this case i think we need use SizedBox() or SizedBox.shrink() because If you need a highly customizable widget with support for a wide range of layout properties, then Container is the way to go. But if you need a lightweight widget that can enforce a fixed size constraint or create a fixed-size gap between widgets, then SizedBox is the clear winner.
sherlockvn
reviewed
Oct 23, 2023
drminh2807
reviewed
Oct 23, 2023
drminh2807
approved these changes
Oct 23, 2023
sherlockvn
approved these changes
Oct 23, 2023
hoangdat
approved these changes
Oct 23, 2023
|
pleaes rebase |
nqhhdev
force-pushed
the
TW-826-improvement-chat-details
branch
from
5a9738e to
11df0c4
Compare
nqhhdev
force-pushed
the
TW-826-improvement-chat-details
branch
from
11df0c4 to
aa9a0c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Resolved:
Screen.Recording.2023-10-19.at.14.40.40.mov
3.mov
2.mov
1.mov