-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-824: install google fonts to fetch font from http #832
Conversation
This PR has been deployed to https://linagora.github.io/twake-on-matrix/832 |
1b6db39
to
db06315
Compare
Better |
assets/google_fonts/Inter-Black.ttf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about to remove all font files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drminh2807 I think it's possible if we use only googlefonts package for web only and do a condition in themes.dart. But is it a good practice? |
let's try :))) |
edbd141
to
85ac777
Compare
@hoangdat added ADR |
you still keep font in pubspec, so web still download font files from assets platform specific asset is not supported yet in flutter |
85ac777
to
32211f6
Compare
@drminh2807 reversed to normal implemention of google fonts, please check again:) |
The base branch was changed.
implementation of https://pub.dev/packages/google_fonts
#824