-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-823 Metadata width height thumbnail blurhash for file sharing #831
Merged
hoangdat
merged 4 commits into
main
from
TW-823-Metadata-width-height-thumbnail-blurhash-for-File-Sharing
Oct 19, 2023
Merged
TW-823 Metadata width height thumbnail blurhash for file sharing #831
hoangdat
merged 4 commits into
main
from
TW-823-Metadata-width-height-thumbnail-blurhash-for-File-Sharing
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
October 17, 2023 11:07
This PR has been deployed to https://linagora.github.io/twake-on-matrix/831 |
drminh2807
reviewed
Oct 18, 2023
drminh2807
reviewed
Oct 18, 2023
pubspec.lock
Outdated
@@ -1550,8 +1550,8 @@ packages: | |||
dependency: "direct main" | |||
description: | |||
path: "." | |||
ref: "twake-supported-0.22.4" | |||
resolved-ref: "7b85a14ebb663ecc25bf55fbb7ceec3a0663515d" | |||
ref: "feat/add-factory-method-for-file-info-and-matrix-file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the description, i have updated it
nqhhdev
changed the title
Tw 823 metadata width height thumbnail blurhash for file sharing
TW-823 Metadata width height thumbnail blurhash for file sharing
Oct 18, 2023
sherlockvn
force-pushed
the
TW-823-Metadata-width-height-thumbnail-blurhash-for-File-Sharing
branch
from
October 19, 2023 02:42
cca6c76
to
1553332
Compare
drminh2807
approved these changes
Oct 19, 2023
sherlockvn
force-pushed
the
TW-823-Metadata-width-height-thumbnail-blurhash-for-File-Sharing
branch
from
October 19, 2023 05:02
1553332
to
2a2bbc0
Compare
hoangdat
approved these changes
Oct 19, 2023
hoangdat
deleted the
TW-823-Metadata-width-height-thumbnail-blurhash-for-File-Sharing
branch
October 19, 2023 05:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged after:
linagora/matrix-dart-sdk#27
demo:
Screen.Recording.2023-10-17.at.17.17.34.mov