TW-728: fix sharing screenshot is not working in IOS #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/822 |
sherlockvn
force-pushed
the
TW-728/fix-share-screenshot-not-working-in-ios
branch
from
5f61bfb to
2a97937
Compare
sherlockvn
force-pushed
the
TW-728/fix-share-screenshot-not-working-in-ios
branch
from
77b57a4 to
c7d2e5a
Compare
nqhhdev
reviewed
Oct 16, 2023
sherlockvn
force-pushed
the
TW-728/fix-share-screenshot-not-working-in-ios
branch
from
c7d2e5a to
256b989
Compare
drminh2807
approved these changes
Oct 17, 2023
sherlockvn
force-pushed
the
TW-728/fix-share-screenshot-not-working-in-ios
branch
from
70e5f75 to
51ca0ae
Compare
hoangdat
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Because the screenshot image need to copy in file on the iOS platform, but the native code is missing the completer for handle async operation, so it have error when sharing in our app, the telegram have the same problem.
Demo sharing screenshot:
RPReplay_Final1697427784.mp4
Demo sharing to the same room as before
Screen.Recording.2023-10-16.at.14.54.20.mov
Demo remove the default share UI when sharing screenshot in IOS
123.mp4