Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable emoji on web #766

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: Enable emoji on web #766

merged 1 commit into from
Oct 9, 2023

Conversation

drminh2807
Copy link
Contributor

@drminh2807 drminh2807 commented Oct 5, 2023 •
edited
Loading

Screenshot 2023-10-05 at 21 16 42

Light weight font file

Screenshot 2023-10-06 at 14 39 57

New index.html

  • Got from this comment
flutter create twake --platforms=web
  • Reference:
  1. https://stackoverflow.com/a/76762811/6652582
  2. https://docs.flutter.dev/platform-integration/web/initialization

@drminh2807 drminh2807 temporarily deployed to PR-766 October 5, 2023 14:25 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This PR has been deployed to https://linagora.github.io/twake-on-matrix/766

@hoangdat
Copy link
Member

hoangdat commented Oct 6, 2023

@drminh2807 any effect for font of other text (especially in chat list item). Please show font info in flutter inspector.

@drminh2807 drminh2807 force-pushed the fix/enable-emoji-on-web branch from b502555 to 5c35be3 Compare October 6, 2023 07:41
@hoangdat
Copy link
Member

hoangdat commented Oct 8, 2023 •
edited
Loading

@drminh2807 please do the change on CI/CD also if needed

@hoangdat hoangdat merged commit 45ef180 into main Oct 9, 2023
3 checks passed
@hoangdat hoangdat deleted the fix/enable-emoji-on-web branch October 9, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherlockvn sherlockvn sherlockvn approved these changes

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@nqhhdev nqhhdev Awaiting requested review from nqhhdev nqhhdev is a code owner

@imGok imGok Awaiting requested review from imGok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drminh2807 @hoangdat @sherlockvn