TW-740: remove change avatar event when user first set his avatar #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/751 |
hoangdat
approved these changes
Oct 4, 2023
imGok
approved these changes
Oct 4, 2023
drminh2807
approved these changes
Oct 5, 2023
hoangdat
deleted the
TW-740/someone-change-avatar-event-still-show-sometimes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Because user can delete their avatar, but the condition
isSomeoneChangeAvatarcheck previous avatar != null, so it still show the event.Resolve:
Update condition for
isSomeoneChangeAvatarDemo:
Screen.Recording.2023-10-04.at.16.38.31.mov