Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-741 : redesign quoted message #748

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

imGok
Copy link
Contributor

@imGok imGok commented Oct 3, 2023

Still left : add preview image thumbnail

#741

Design :
image

Demo :
image

@imGok imGok temporarily deployed to PR-748 October 3, 2023 15:09 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This PR has been deployed to https://linagora.github.io/twake-on-matrix/748

@hoangdat
Copy link
Member

hoangdat commented Oct 3, 2023

image

IMO, background for quote need to expand with bubble

@hoangdat
Copy link
Member

hoangdat commented Oct 3, 2023

can you demo:

  • case 1: long quote
  • case 2: long quote in web
  • case 3: short quote in web

@imGok imGok temporarily deployed to PR-748 October 4, 2023 11:14 — with GitHub Actions Inactive
@imGok
Copy link
Contributor Author

imGok commented Oct 4, 2023

image
image

@imGok
Copy link
Contributor Author

imGok commented Oct 4, 2023

@hoangdat I increased font weight because w500 didn't look like figma, and added expanded

@hoangdat
Copy link
Member

hoangdat commented Oct 6, 2023

@sherlockvn please help him

@hoangdat hoangdat merged commit baf1cad into main Oct 6, 2023
3 checks passed
@hoangdat hoangdat deleted the TW-741-style-reply-message branch October 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants