Fix appimage build on Linux #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/742 |
tk-nguyen
force-pushed
the
fix-appimage-builds
branch
from
f96df78 to
3be0cca
Compare
tk-nguyen
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
hoangdat
reviewed
Oct 5, 2023
Fixed library name and removed unneeded packages Use azure mirror, skip tests Because GH Actions docker is flaky Use png file for icon Added additional libraries Correct the distro codename
tk-nguyen
force-pushed
the
fix-appimage-builds
branch
from
3be0cca to
891f0f1
Compare
|
is it ok for merge? @tk-nguyen |
drminh2807
approved these changes
Oct 10, 2023
Should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need some more testing with different distros: Fedora, Debian, Ubuntu, Centos, Arch, ...
Closes: #674