TW-729,730: swipe to close page, swipe images and videos #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/739 |
|
can you hide the app bar of previewer when you swipe? |
|
Pls demo for IOS, Web responsive |
|
don't we have swipe action to reply also ? or it's not the same movement |
nqhhdev
reviewed
Oct 3, 2023
drminh2807
reviewed
Oct 3, 2023
hoangdat
reviewed
Oct 4, 2023
sherlockvn
changed the title
I will make an a ticket in additional section, and do it later, because I have tried, but not so easy |
Screen.Recording.2023-10-04.at.11.07.30.mov |
Yes, we can swipe right to left to reply for both message of sender and receiver |
drminh2807
reviewed
Oct 4, 2023
sherlockvn
force-pushed
the
fix/swipe-to-close-page
branch
from
ef006f3 to
0820f31
Compare
drminh2807
reviewed
Oct 5, 2023
drminh2807
approved these changes
Oct 5, 2023
nqhhdev
approved these changes
Oct 5, 2023
sherlockvn
force-pushed
the
fix/swipe-to-close-page
branch
from
37298bf to
fefa013
Compare
hoangdat
approved these changes
Oct 5, 2023
hoangdat
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference:
https://pub.dev/packages/interactiveviewer_gallery
Demo mobile:
Screen.Recording.2023-10-03.at.17.29.00.mov
Demo forward case:
Screen.Recording.2023-10-04.at.15.53.47.mov
Demo mobile after update image viewer:
Screen.Recording.2023-10-05.at.10.32.08.mov
Demo web after update seekbar, image viewer app bar
Screen.Recording.2023-10-05.at.10.36.13.mov