TW-692: New design for settings screen #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
imGok and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/707 |
nqhhdev
changed the title
imGok
reviewed
Sep 29, 2023
hoangdat
reviewed
Oct 2, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
drminh2807
reviewed
Oct 2, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
drminh2807
reviewed
Oct 2, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
drminh2807
reviewed
Oct 2, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
sherlockvn
reviewed
Oct 2, 2023
drminh2807
reviewed
Oct 2, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
sherlockvn
reviewed
Oct 2, 2023
sherlockvn
reviewed
Oct 2, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Oct 3, 2023
nqhhdev
force-pushed
the
TW-692-new-design-for-settings-screen
branch
from
8c89530 to
287c721
Compare
hoangdat
reviewed
Oct 3, 2023
sherlockvn
reviewed
Oct 3, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Oct 3, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Oct 3, 2023
hoangdat
reviewed
Oct 3, 2023
I am not a fan of this loading. What is the problem of the old loading dialog? |
sherlockvn
approved these changes
Oct 4, 2023
drminh2807
approved these changes
Oct 4, 2023
nqhhdev
force-pushed
the
TW-692-new-design-for-settings-screen
branch
from
33aa7b2 to
bfe4775
Compare
sherlockvn
reviewed
Oct 4, 2023
sherlockvn
reviewed
Oct 4, 2023
sherlockvn
reviewed
Oct 4, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile_view_mobile.dart
Show resolved
Hide resolved
sherlockvn
reviewed
Oct 4, 2023
lib/pages/settings_dashboard/settings_profile/settings_profile_view_web.dart
Show resolved
Hide resolved
sherlockvn
approved these changes
Oct 4, 2023
hoangdat
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Resolved
WEB
Screen.Recording.2023-10-04.at.14.03.20.mov
Mobile
mobile.mov