TW-633 feat: preview pdf on web client #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imGok
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/695 |
imGok
changed the title
sherlockvn
reviewed
Sep 29, 2023
sherlockvn
reviewed
Sep 29, 2023
sherlockvn
reviewed
Sep 29, 2023
hoangdat
reviewed
Oct 2, 2023
hoangdat
reviewed
Oct 2, 2023
hoangdat
reviewed
Oct 2, 2023
hoangdat
reviewed
Oct 2, 2023
hoangdat
reviewed
Oct 2, 2023
hoangdat
reviewed
Oct 2, 2023
drminh2807
approved these changes
Oct 3, 2023
sherlockvn
approved these changes
Oct 3, 2023
hoangdat
reviewed
Oct 5, 2023
imGok
force-pushed
the
TW-633-preview-pdf-web
branch
from
8ea4a97 to
60913c8
Compare
imGok
force-pushed
the
TW-633-preview-pdf-web
branch
2 times, most recently
from
8ea4a97 to
feecc08
Compare
imGok
force-pushed
the
TW-633-preview-pdf-web
branch
2 times, most recently
from
518197e to
97ee9da
Compare
sherlockvn
reviewed
Oct 5, 2023
sherlockvn
reviewed
Oct 5, 2023
sherlockvn
approved these changes
Oct 5, 2023
hoangdat
reviewed
Oct 6, 2023
nqhhdev
force-pushed
the
TW-633-preview-pdf-web
branch
from
b601ad5 to
ceaec7a
Compare
hoangdat
reviewed
Oct 6, 2023
sherlockvn
approved these changes
Oct 6, 2023
imGok
force-pushed
the
TW-633-preview-pdf-web
branch
from
ead7c21 to
74c204b
Compare
hoangdat
approved these changes
Oct 6, 2023
imGok
force-pushed
the
TW-633-preview-pdf-web
branch
from
74c204b to
061cd53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WEB] Open file on new tab if it's a PDF, if it's not then download it
#633
Demo :
Twake.-.Google.Chrome.2023-09-28.17-03-18.mp4
Error :
Twake.-.Google.Chrome.2023-09-28.17-01-14.mp4
Toast :
Android.Emulator.-.Resizable_Experimental_API_33_5554.2023-10-05.14-56-30.mp4
Twake.-.Google.Chrome.2023-10-05.14-58-54.mp4