TW-504: config notifications for default push rules #568
+178
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
imGok and
drminh2807
as code owners
sherlockvn
changed the title
hoangdat
reviewed
Sep 7, 2023
| '.m.rule.member_event', | ||
| (c) => L10n.of(c)!.memberChanges, | ||
| 'm.rule.change_group_name', | ||
| (c) => "Group chat name change", |
| '.m.rule.suppress_notices', | ||
| (c) => L10n.of(c)!.botMessages, | ||
| 'm.rule.change_avatar_group', | ||
| (c) => "Group chat avatar change", |
lib/widgets/matrix.dart
Outdated
| @@ -448,6 +449,77 @@ class MatrixState extends State<Matrix> with WidgetsBindingObserver { | |||
| createVoipPlugin(); | |||
| } | |||
|
|
|||
| Future<void> _setUpUserDefinedPushRules(Client client) async { | |||
| await client.setPushRuleEnabled( | |||
There was a problem hiding this comment.
use Future.wait for some parallel rules
lib/widgets/matrix.dart
Outdated
| final homeServerUrlInterceptor = getIt.get<DynamicUrlInterceptors>( | ||
| instanceName: NetworkDI.homeServerUrlInterceptorName, | ||
| ); | ||
| Logs().d( | ||
| 'MatrixState::_setUpHomeServer: ${homeServerUrlInterceptor.baseUrl}', | ||
| ); | ||
| homeServerUrlInterceptor.changeBaseUrl(homeServerUri.toString()); | ||
| _setUpUserDefinedPushRules(client); |
There was a problem hiding this comment.
Please make sure to call it one time in login?
There was a problem hiding this comment.
please make sure this will not make conflict with other setup in other device?
|
IMO, it is good. Can you write ADRs to describe about:
|
sherlockvn
changed the title
drminh2807
reviewed
Sep 11, 2023
| } | ||
|
|
||
| bool containsRule(String ruleId) { | ||
| final rule = devicePushRules?.override?.firstWhere((PushRule rule) { |
There was a problem hiding this comment.
Suggested change
| final rule = devicePushRules?.override?.firstWhere((PushRule rule) { | |
| final rule = devicePushRules?.override?.any((rule) => rule.ruleId == ruleId); |
| @@ -522,7 +613,7 @@ class MatrixState extends State<Matrix> with WidgetsBindingObserver { | |||
| } | |||
| } | |||
|
|
|||
| void _setUpHomeServer(Uri homeServerUri) { | |||
| void _setUpHomeServer(Uri homeServerUri) async { | |||
hoangdat
reviewed
Sep 12, 2023
There was a problem hiding this comment.
please show demo for new settings
hoangdat
reviewed
Sep 12, 2023
| } | ||
| } | ||
|
|
||
| bool containsRule(String ruleId) { |
There was a problem hiding this comment.
Where you can put this check? Before or after sync?
hoangdat
reviewed
Dec 18, 2023
| ], | ||
| ), | ||
| client.setupUserDefinedPushRule( | ||
| ruleId: 'm.rule.set_me_as_admin', |
There was a problem hiding this comment.
Suggested change
| ruleId: 'm.rule.set_me_as_admin', | |
| ruleId: 'm.rule.change_power_level', |
sherlockvn
requested review from
hieutbui and
tddang-linagora
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
RPReplay_Final1694021601.MP4