Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-1796: Standarlize Appbar and Appgrid popup #1880

Merged
merged 5 commits into from
Jun 25, 2024
Merged

TW-1796: Standarlize Appbar and Appgrid popup #1880

merged 5 commits into from
Jun 25, 2024

Conversation

hieutbui
Copy link
Member

@hieutbui hieutbui commented Jun 18, 2024 •
edited
Loading

Ticket

Resolved

standalize.mp4

@hieutbui hieutbui changed the title [WIP] TW-1796: Change app grid button icon [WIP] TW-1796: Standarlize Appbar and Appgrid popup Jun 18, 2024
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1880

@hieutbui hieutbui force-pushed the TW-1796-Standardlize-Appbar-and-Appgrid-popup branch from 3013408 to a52536f Compare June 19, 2024 08:33
@hieutbui hieutbui changed the title [WIP] TW-1796: Standarlize Appbar and Appgrid popup TW-1796: Standarlize Appbar and Appgrid popup Jun 20, 2024
@nqhhdev
Copy link
Member

nqhhdev commented Jun 21, 2024 •
edited by hieutbui
Loading

IMO: We keep all appgird icons, only update configurations/app_dashboard.json file.

  • Remove if not used
  • Update ADR docs/configurations/app_grid_configuration.md

@hieutbui hieutbui force-pushed the TW-1796-Standardlize-Appbar-and-Appgrid-popup branch from 5c397cf to 0be7451 Compare June 24, 2024 03:55
@hieutbui hieutbui force-pushed the TW-1796-Standardlize-Appbar-and-Appgrid-popup branch from 0be7451 to d48e220 Compare June 24, 2024 04:01
nqhhdev
nqhhdev approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@nqhhdev nqhhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on WEB (Safari, chrome, Arc, Firefox) works well.

@Te-Z Te-Z merged commit 613c470 into main Jun 25, 2024
7 checks passed
@Te-Z Te-Z deleted the TW-1796-Standardlize-Appbar-and-Appgrid-popup branch June 25, 2024 13:07
@nqhhdev nqhhdev mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherlockvn sherlockvn sherlockvn left review comments

@nqhhdev nqhhdev nqhhdev approved these changes

@Te-Z Te-Z Te-Z approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat hoangdat is a code owner

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hieutbui @nqhhdev @Te-Z @sherlockvn