Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1772: Prevent infinity contact loop #1782

Merged
merged 4 commits into from
May 21, 2024

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented May 20, 2024

Ticket:

#1772

Resolved:

  • prevent infinity contact loop
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.12.24.24.mp4
  • showing no contact
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.16.17.25.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.17.13.11.mp4
  • show recent contact in contact tab
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.15.51.20.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.17.35.33.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-21.at.00.13.26.mp4

Web:

Screen.Recording.2024-05-21.at.01.15.15.mov
1.mov

@nqhhdev nqhhdev force-pushed the TW-1772-handle-contacts-infinity-loop branch from 52239e9 to cbb4126 Compare May 20, 2024 05:32
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1782

@nqhhdev nqhhdev changed the title TW-1772: Prevent infinity contact loop [WIP] TW-1772: Prevent infinity contact loop May 20, 2024
@nqhhdev nqhhdev force-pushed the TW-1772-handle-contacts-infinity-loop branch from 35bfa15 to 92dc493 Compare May 20, 2024 10:18
@nqhhdev nqhhdev force-pushed the TW-1772-handle-contacts-infinity-loop branch from 92dc493 to d1cc011 Compare May 20, 2024 10:37
@nqhhdev nqhhdev changed the title [WIP] TW-1772: Prevent infinity contact loop TW-1772: Prevent infinity contact loop May 20, 2024
@hoangdat
Copy link
Member

please rebase. LGTM

@hoangdat hoangdat merged commit 4eb4c09 into main May 21, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1772-handle-contacts-infinity-loop branch May 21, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants