-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1772: Prevent infinity contact loop #1782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
hieutbui,
tddang-linagora and
Te-Z
as code owners
May 20, 2024 05:28
nqhhdev
force-pushed
the
TW-1772-handle-contacts-infinity-loop
branch
from
May 20, 2024 05:32
52239e9
to
cbb4126
Compare
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1782 |
nqhhdev
changed the title
TW-1772: Prevent infinity contact loop
[WIP] TW-1772: Prevent infinity contact loop
May 20, 2024
nqhhdev
force-pushed
the
TW-1772-handle-contacts-infinity-loop
branch
from
May 20, 2024 10:18
35bfa15
to
92dc493
Compare
nqhhdev
force-pushed
the
TW-1772-handle-contacts-infinity-loop
branch
from
May 20, 2024 10:37
92dc493
to
d1cc011
Compare
nqhhdev
changed the title
[WIP] TW-1772: Prevent infinity contact loop
TW-1772: Prevent infinity contact loop
May 20, 2024
hoangdat
reviewed
May 20, 2024
sherlockvn
approved these changes
May 21, 2024
please rebase. LGTM |
nqhhdev
force-pushed
the
TW-1772-handle-contacts-infinity-loop
branch
from
May 21, 2024 03:56
78b9d7e
to
dc2f0a8
Compare
hoangdat
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
#1772
Resolved:
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.12.24.24.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.16.17.25.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.17.13.11.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.15.51.20.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-20.at.17.35.33.mp4
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-21.at.00.13.26.mp4
Web:
Screen.Recording.2024-05-21.at.01.15.15.mov
1.mov