[PART-2] TW-1690: Show external channel after search

[hieutbui]

Ticket

• Join external Matrix channel #1690

DOD:

• Implement search external channel in view
• Create view for external channel
• Add into search view
• join room
• view joined room
• Handle actions when click join/view buttons

Resolved:

• Web:

public.web.mp4

• Android:

public.android.mp4

[github-actions]

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1775

[hieutbui]

• Currently, we are unable to implement the feature of viewing or peeking into a public room that a user has not joined due to limitations in the Matrix federation protocol.
• There are two APIs available for this purpose: _matrix/client/v3/rooms/!roomId:server.name/initialSync and _matrix/client/v3/events, However, when calling these APIs, an error is returned:

{
    "errcode": "M_FORBIDDEN",
    "error": "User @username:server.name not in room !roomId:server.name, and room previews are disabled"
}

• This issue is recognized within the Matrix community, and efforts are underway to address it. Relevant discussions and efforts can be found at:
  • Matrix Spec Proposals: MSC2444: peeking over federation via /peek matrix-org/matrix-spec-proposals#2444
  • Element Web Issues: Peeking a room over federation without previews allowed spins forever & cannot join element-hq/element-web#12500

[hoangdat]

• join but can not send message ???

[hieutbui]

• join but can not send message ???

This is because there are some rooms that limit members from sending messages. I updated the demo video. Please check it!

[Te-Z]

Hi @hieutbui , I have a few more comments:

• the screen behind loading dialog changes while loading. IMO it should stay the same since the text in search bar is still the same
• I wasn't able to join #matrix:matrix.org
• when I open a joined room (in my case matrix news) the text appears then disappear. And I have to tap the reload icon to see its content

screen-20240523-170838.mp4

[hieutbui]

Hi @hieutbui , I have a few more comments:

• the screen behind loading dialog changes while loading. IMO it should stay the same since the text in search bar is still the same
• I wasn't able to join #matrix:matrix.org
• when I open a joined room (in my case matrix news) the text appears then disappear. And I have to tap the reload icon to see its content

screen-20240523-170838.mp4

Hi @Te-Z, I tested it:

• On my side, the case that search results disappeared only happened 1 time. I'm trying to figure out the root cause. Thought it is because of the sync.
• Case can't join. It is because of the API timeout.
• Case need reload to see messages, I believe It is a common problem that we already know. For other rooms in our server, this also happens sometimes.

[Te-Z]

Hi @hieutbui , I have a few more comments:

• the screen behind loading dialog changes while loading. IMO it should stay the same since the text in search bar is still the same
• I wasn't able to join #matrix:matrix.org
• when I open a joined room (in my case matrix news) the text appears then disappear. And I have to tap the reload icon to see its content

screen-20240523-170838.mp4

Hi @Te-Z, I tested it:

• On my side, the case that search results disappeared only happened 1 time. I'm trying to figure out the root cause. Thought it is because of the sync.
• Case can't join. It is because of the API timeout.
• Case need reload to see messages, I believe It is a common problem that we already know. For other rooms in our server, this also happens sometimes.

Hi @hieutbui I retried and I'm not able to reproduce the search bug. I had it multiple times the last time but looks like it's gone now.
Ok for the two other points

[sherlockvn]

create a streamSubscription, then dispose it when done

[hieutbui]

Updated

[nqhhdev]

IMO: should use Future<void>

[nqhhdev]

Why need to pop for platforms other than mobile?

[hoangdat]

not in roadmap