[Android] TW-1696: Change app icon #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieutbui
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1755 |
sherlockvn
approved these changes
May 13, 2024
hoangdat
reviewed
May 13, 2024
| @@ -7,6 +7,6 @@ | |||
| <bitmap android:gravity="center" android:src="@drawable/splash"/> | |||
| </item> | |||
| <item> | |||
| <bitmap android:gravity="bottom" android:src="@drawable/branding" android:bottom="32dp"/> | |||
There was a problem hiding this comment.
I removed it cause it doesn't have any effects at all, and <bitmap> also doesn't have attribute android:bottom.
RF:
- https://developer.android.com/reference/android/graphics/drawable/BitmapDrawable#summary
- https://developer.android.com/guide/topics/resources/drawable-resource#XmlBitmap
If we still need to move the branding up a bit from the bottom, the code should be:
<item android:bottom="32dp">
<bitmap android:gravity="bottom" android:src="@drawable/branding"/>
</item>
|
|
hoangdat
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOD
Resolved
android.28.mp4
android.34.mp4