Tw 1650 part i/find memory leak in chat #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en not used any more
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1740 |
hoangdat
reviewed
May 6, 2024
| @@ -390,7 +390,7 @@ class MatrixState extends State<Matrix> | |||
| LoginState state, | |||
| Client currentClient, | |||
| ) async { | |||
| _cancelSubs(currentClient.clientName); | |||
| await _cancelSubs(currentClient.clientName); | |||
hoangdat
reviewed
May 6, 2024
Te-Z
approved these changes
May 6, 2024
|
sherlockvn
force-pushed
the
TW-1650-part-I/find-memory-leak-in-chat
branch
from
98740d7 to
1dc2de9
Compare
hoangdat
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Screen.Recording.2024-05-03.at.14.19.32.mov
After:
Screen.Recording.2024-05-03.at.14.24.02.mov