TW-1456: Button new chat doesn t work #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Te-Z
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
hieutbui and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1596 |
|
Also test case responsive: tablet and mobile in web |
sherlockvn
reviewed
Mar 18, 2024
sherlockvn
reviewed
Mar 18, 2024
sherlockvn
reviewed
Mar 18, 2024
lib/pages/profile_info/profile_info_body/profile_info_body_view.dart
Outdated
Show resolved
Hide resolved
sherlockvn
reviewed
Mar 18, 2024
lib/pages/profile_info/profile_info_body/profile_info_body_view.dart
Outdated
Show resolved
Hide resolved
nqhhdev
reviewed
Mar 18, 2024
nqhhdev
reviewed
Mar 18, 2024
nqhhdev
reviewed
Mar 18, 2024
nqhhdev
reviewed
Mar 18, 2024
lib/pages/profile_info/profile_info_body/profile_info_body_view_style.dart
Outdated
Show resolved
Hide resolved
Ripple shape is not so beutifull
or only take the ripple for the Copy button. |
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
f93113c to
689d4aa
Compare
Updated @hoangdat . WDYT ? Capture.video.du.18-03-2024.10.46.37.webm |
There you go @sherlockvn Capture.video.du.18-03-2024.10.56.58.webm |
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
689d4aa to
6ac7703
Compare
hoangdat
reviewed
Mar 19, 2024
lib/pages/chat_details/participant_list_item/participant_list_item.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 19, 2024
lib/pages/chat_details/participant_list_item/participant_list_item.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 19, 2024
lib/pages/chat_details/participant_list_item/participant_list_item.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 19, 2024
lib/pages/chat_details/participant_list_item/participant_list_item.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 19, 2024
lib/pages/profile_info/profile_info_body/profile_info_body.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 19, 2024
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
daab3b3 to
f6cd9ac
Compare
demonstration videos updated |
hoangdat
reviewed
Mar 28, 2024
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
f6cd9ac to
dbd04f6
Compare
nqhhdev
reviewed
Mar 28, 2024
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
dbd04f6 to
8a44b28
Compare
nqhhdev
reviewed
Mar 28, 2024
lib/pages/profile_info/copiable_profile_row/copiable_profile_row.dart
Outdated
Show resolved
Hide resolved
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
abca529 to
8e6f26a
Compare
|
Hi @Te-Z , back button in profile info still not go to chat details Screen.Recording.2024-03-28.at.22.23.59.mov |
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
8e6f26a to
1fb8307
Compare
Te-Z
force-pushed
the
TW-1456/button-new-doesn-t-work
branch
from
1fb8307 to
6ae0b91
Compare
hoangdat
approved these changes
Mar 28, 2024
nqhhdev
approved these changes
Mar 29, 2024
sherlockvn
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1456
Resolution:
Capture.video.du.28-03-2024.15.19.59.webm
Capture.video.du.28-03-2024.15.31.53.webm