-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1356: Reword accounts picker #1408
Conversation
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1408 |
39cae14
to
be9ee7c
Compare
be9ee7c
to
5bdb9bb
Compare
5bdb9bb
to
ae2b8ba
Compare
ae2b8ba
to
962651b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherlockvn please try to test it with current branch
962651b
to
125e1a1
Compare
The base branch was changed.
Pls upload new demo (IOS, Mobile) for this case. |
125e1a1
to
a617c41
Compare
lib/pages/settings_dashboard/settings_profile/settings_profile_view_mobile_style.dart
Outdated
Show resolved
Hide resolved
lib/pages/settings_dashboard/settings_profile/settings_profile_view_mobile.dart
Outdated
Show resolved
Hide resolved
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.14.11.55.mp4I found some issue:
|
Issue related to Back button in account picker Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.14.16.27.mp4
|
lib/pages/settings_dashboard/settings_profile/settings_profile.dart
Outdated
Show resolved
Hide resolved
Issue released to switch account: Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.14.28.06.mp4
|
28b94bd
to
b2db781
Compare
d91a1ea
to
45fb898
Compare
45fb898
to
6dc84c5
Compare
6dc84c5
to
494e5ee
Compare
494e5ee
to
e0f6986
Compare
i tested the case log out again and it works well |
Ticket: #1356
Root cause:
The currentProfileNotifier is updated multiple times during the build of chat list, and when its first build, the
_activeClient
default is first client in the all clients.-> Solution: move
currentProfileNotifier
to only the TwakeHeader, and make sure it avatar updated only one if have the new change in avatar or the inital build. Add the condition for check the_activeClient
for update the avatar correctlyResolved (23 - May)
Simulator.Screen.Recording.-.iPhone.14.-.2024-05-23.at.12.27.01.mp4
logout.mp4