Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1356: Reword accounts picker #1408

Merged
merged 4 commits into from
May 31, 2024
Merged

Conversation

sherlockvn
Copy link
Collaborator

@sherlockvn sherlockvn commented Jan 29, 2024

Ticket: #1356

Root cause:

The currentProfileNotifier is updated multiple times during the build of chat list, and when its first build, the _activeClient default is first client in the all clients.

-> Solution: move currentProfileNotifier to only the TwakeHeader, and make sure it avatar updated only one if have the new change in avatar or the inital build. Add the condition for check the _activeClient for update the avatar correctly

Resolved (23 - May)

Simulator.Screen.Recording.-.iPhone.14.-.2024-05-23.at.12.27.01.mp4
  • Switch and logout
logout.mp4

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1408

Te-Z
Te-Z previously approved these changes Mar 4, 2024
nqhhdev
nqhhdev previously approved these changes Mar 21, 2024
hoangdat
hoangdat previously approved these changes Apr 17, 2024
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherlockvn please try to test it with current branch

@sherlockvn sherlockvn force-pushed the TW-1356/reword-accounts-picker branch from 962651b to 125e1a1 Compare May 13, 2024 09:44
@nqhhdev nqhhdev changed the base branch from upgrade_3.16 to main May 13, 2024 15:52
@nqhhdev nqhhdev dismissed stale reviews from hoangdat, Te-Z, and themself May 13, 2024 15:52

The base branch was changed.

@nqhhdev
Copy link
Member

nqhhdev commented May 13, 2024

Pls upload new demo (IOS, Mobile) for this case.

@hoangdat
Copy link
Member

image

@nqhhdev
Copy link
Member

nqhhdev commented May 22, 2024

Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.14.11.55.mp4

I found some issue:

  • Case 1: When I click on add another account , some time lagging
  • Case 2: Open settings → click on profile → add another account → login success → back to settings screen ??? IMO: why don't back to chat list screen?

@nqhhdev
Copy link
Member

nqhhdev commented May 22, 2024

Issue related to Back button in account picker

Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.14.16.27.mp4
  • Case 1: Click on icon avatar in chat list → open profile → click on add another account → open homeserver picker → I click on back button → back to chat list.

    • Why don't back to profile?
  • Case 2: Open settings → Open profile → Click on add another account → open homeserver picker → I click on back button → back to settings.

    • Why don't back to settings tab?
    • Still highlight profile button?

@nqhhdev
Copy link
Member

nqhhdev commented May 22, 2024

Issue released to switch account:

Simulator.Screen.Recording.-.iPhone.14.-.2024-05-22.at.14.28.06.mp4
  • Case 1: Open settings → Open profile → Switch to another account → switch account success back to settings.
    • Why need to back settings? Why don't back to profile?
  • Case 2: In chat list same question

@hoangdat
Copy link
Member

hoangdat commented May 23, 2024

  • we still not support multiple account in web app
image

@nqhhdev nqhhdev force-pushed the TW-1356/reword-accounts-picker branch from 28b94bd to b2db781 Compare May 23, 2024 03:36
@nqhhdev nqhhdev force-pushed the TW-1356/reword-accounts-picker branch from d91a1ea to 45fb898 Compare May 24, 2024 16:19
@nqhhdev nqhhdev force-pushed the TW-1356/reword-accounts-picker branch from 45fb898 to 6dc84c5 Compare May 24, 2024 16:19
@nqhhdev nqhhdev force-pushed the TW-1356/reword-accounts-picker branch from 6dc84c5 to 494e5ee Compare May 25, 2024 06:52
@sherlockvn
Copy link
Collaborator Author

i tested the case log out again and it works well

@nqhhdev nqhhdev changed the title Tw 1356: Reword accounts picker TW-1356: Reword accounts picker May 30, 2024
@Te-Z
Copy link
Contributor

Te-Z commented May 30, 2024

  • we still not support multiple account in web app
image

IMO we should create a ticket to support this feature on web. WDYT ?

@hoangdat hoangdat merged commit 9759166 into main May 31, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1356/reword-accounts-picker branch May 31, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants