TW-1255: Support selectable pinned events #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imGok
requested review from
sherlockvn,
hoangdat,
dab246 and
nqhhdev
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1264 |
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
e20ddf1 to
5693349
Compare
imGok
changed the title
|
Please record a mobile demo, I need to see detailed behavior and I think better than screenshots |
nqhhdev
reviewed
Jan 4, 2024
nqhhdev
reviewed
Jan 4, 2024
sherlockvn
reviewed
Jan 8, 2024
|
The |
|
Remove this button, because we don't have function for it right now |
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
9369fb8 to
a96ecfb
Compare
imGok
changed the title
imGok
changed the title
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
c7ad30e to
f494277
Compare
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
f494277 to
cef22f1
Compare
|
In a room that you don't have permission to remove pinned messages like |
Dont need to show the selecable widget if you dont have permission |
sherlockvn
reviewed
Jan 10, 2024
sherlockvn
reviewed
Jan 10, 2024
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
e6bfe78 to
0776af4
Compare
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
0776af4 to
a5d8d65
Compare
I think it can be done later, because to be done, we need to get current user permission, and get the pinned message permission, then compare |
sherlockvn
previously approved these changes
Jan 12, 2024
nqhhdev
previously approved these changes
Jan 12, 2024
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
a5d8d65 to
7c8209d
Compare
imGok
dismissed stale reviews from nqhhdev and sherlockvn
The base branch was changed.
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
7c8209d to
6a572de
Compare
imGok
force-pushed
the
TW-1255-support-select-pinned-events
branch
from
6a572de to
7d878e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1255
Twake.Chat.-.Google.Chrome.2024-01-04.16-53-50.mp4
Screencast.from.08-01-2024.10.45.48.webm
View from non-admin