Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-683: Fix multiple linebreaks in a row #1101

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

imGok
Copy link
Contributor

@imGok imGok commented Dec 11, 2023

#638

linagora/flutter_matrix_html#11

Twake.Chat.-.Google.Chrome.2023-12-11.16-20-52.mp4
Android.Emulator.-.Resizable_Experimental_API_33_5554.2023-12-12.15-05-10.mp4

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1101

@nqhhdev
Copy link
Member

nqhhdev commented Dec 12, 2023

I don't see a demo on mobile, Please update completely

@hoangdat
Copy link
Member

it is ok for me

image

@sherlockvn
Copy link
Collaborator

it's works for me too, please explain about your solution more. I'm curious :)

@imGok
Copy link
Contributor Author

imGok commented Dec 13, 2023

it's works for me too, please explain about your solution more. I'm curious :)

Please take a look to the ADR ! :)

@hoangdat
Copy link
Member

@imGok did you investigate on this: #1135

@imGok
Copy link
Contributor Author

imGok commented Dec 16, 2023

@imGok did you investigate on this: #1135

When we reply to a link, the widget "TwakeCleanRichText" is displayed
When we reply to a simple text, the widget "HtmlMessage" is displayed

I fixed the issue by removing extra newlines when sending a message AND supporting "br" tag in htmlmessage

@imGok imGok force-pushed the TW-638-linebreaks-messages branch from 6638e2b to b3dd975 Compare December 16, 2023 09:07
@imGok imGok changed the title TW-683: Update pub lock TW-683: Fix multiple linebreaks in a row Dec 16, 2023
@hoangdat
Copy link
Member

please update the pubspec

@imGok imGok force-pushed the TW-638-linebreaks-messages branch from b3dd975 to cde2fce Compare December 18, 2023 07:51
@hoangdat hoangdat merged commit 0acb3cf into new_app_id Dec 18, 2023
3 checks passed
@hoangdat hoangdat deleted the TW-638-linebreaks-messages branch December 18, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants