New version 2.4.5

CHANGELOG.md

@@ -1,3 +1,24 @@
+## [2.4.5+2330] - 2023-12-11
+
+### Added
+
+- Create unencrypted Direct Message
+- Preview image before sending
+- Search for unencrypted message
+- Add NSE to get plain notification
+- profile info
+
+### Changed
+
+- new app id
+- Jump to message
+- Refactor Message widget
+- Update correct style for app
+
+### Fixed
+
+- thumbnail image in preview link
+
 ## [2.4.2+2330] - 2023-11-28
 
 ### Added
@@ -2070,6 +2091,8 @@ interesting devices. If you have one, I would very like to see some screenshots
 This CHANGELOG.md was generated with [**Changelog for
 Dart**](https://pub.dartlang.org/packages/changelog)
 
+[2.4.5+2330]: https://github.com/linagora/twake-on-matrix/releases/tag/2.4.5+2330
+
 [2.4.2+2330]: https://github.com/linagora/twake-on-matrix/releases/tag/2.4.2
 
 [2.4.1+2330]: https://github.com/linagora/twake-on-matrix/releases/tag/2.4.1

PRIVACY.md

@@ -77,7 +77,7 @@ A typical push notification could look like this:
     },
     "devices": [
       {
-        "app_id": "com.twake.twake",
+        "app_id": "app.twake.android.chat",
         "pushkey": "V2h5IG9uIGVhcnRoIGRpZCB5b3UgZGVjb2RlIHRoaXM/",
         "pushkey_ts": 12345678,
         "data": {},

android/app/build.gradle

@@ -44,7 +44,7 @@ android {
     }
 
     defaultConfig {
-        applicationId "com.twake.twake"
+        applicationId "app.twake.android.chat"
         minSdkVersion 23
         targetSdkVersion 33
         versionCode flutterVersionCode.toInteger()

android/app/google-services.json

@@ -6,6 +6,45 @@
     "storage_bucket": "twake-195010.appspot.com"
   },
   "client": [
+    {
+      "client_info": {
+        "mobilesdk_app_id": "1:492265884073:android:da793d03162cb7db6b5cb8",
+        "android_client_info": {
+          "package_name": "app.twake.android.chat"
+        }
+      },
+      "oauth_client": [
+        {
+          "client_id": "492265884073-g537tkljd8ilrg4c63t0s86fgk97mol7.apps.googleusercontent.com",
+          "client_type": 3
+        }
+      ],
+      "api_key": [
+        {
+          "current_key": "AIzaSyC7c2xkmUpHo9i-O0bsm2BRHnZD1LPi-sU"
+        },
+        {
+          "current_key": "AIzaSyAX6d-jWjhiYiP2RsRdWTrpKt9yCW0M5Zc"
+        }
+      ],
+      "services": {
+        "appinvite_service": {
+          "other_platform_oauth_client": [
+            {
+              "client_id": "492265884073-g537tkljd8ilrg4c63t0s86fgk97mol7.apps.googleusercontent.com",
+              "client_type": 3
+            },
+            {
+              "client_id": "492265884073-758idkadb1l2kh348fk84rn13su5rks6.apps.googleusercontent.com",
+              "client_type": 2,
+              "ios_info": {
+                "bundle_id": "com.linagora.twake"
+              }
+            }
+          ]
+        }
+      }
+    },
     {
       "client_info": {
         "mobilesdk_app_id": "1:492265884073:android:fba0d50aace57d8d",
@@ -14,6 +53,14 @@
         }
       },
       "oauth_client": [
+        {
+          "client_id": "492265884073-4s9mhnk9281tpitd9s9v35rc65iace3l.apps.googleusercontent.com",
+          "client_type": 1,
+          "android_info": {
+            "package_name": "com.twake.twake",
+            "certificate_hash": "48feee1175a3f98d1a08db10c70fe631eac1dfd3"
+          }
+        },
         {
           "client_id": "492265884073-e89325dclv982tp2tbjpmi57l95r1r4o.apps.googleusercontent.com",
           "client_type": 1,
@@ -28,6 +75,9 @@
         }
       ],
       "api_key": [
+        {
+          "current_key": "AIzaSyC7c2xkmUpHo9i-O0bsm2BRHnZD1LPi-sU"
+        },
         {
           "current_key": "AIzaSyAX6d-jWjhiYiP2RsRdWTrpKt9yCW0M5Zc"
         }

android/app/src/debug/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.twake.twake">
+    package="app.twake.android.chat">
     <!-- The INTERNET permission is required for development. Specifically,
          the Flutter tool needs it to communicate with the running application
          to allow setting breakpoints, to provide hot reload, etc.

android/app/src/main/AndroidManifest.xml

@@ -1,6 +1,6 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           xmlns:tools="http://schemas.android.com/tools"
-    package="com.twake.twake" android:installLocation="auto">
+    package="app.twake.android.chat" android:installLocation="auto">
     <!-- io.flutter.app.FlutterApplication is an android.app.Application that
          calls FlutterMain.startInitialization(this); in its onCreate method.
          In most cases you can leave this as-is, but you if you want to provide
@@ -141,7 +141,7 @@
             android:value="2" />
         <provider
             android:name="com.superlist.super_native_extensions.DataProvider"
-            android:authorities="com.twake.twake.SuperClipboardDataProvider"
+            android:authorities="app.twake.android.chat.SuperClipboardDataProvider"
             android:exported="true"
             android:grantUriPermissions="true" >
         </provider>

android/app/src/main/kotlin/com/twake/twake/FcmPushService.kt → android/app/src/main/kotlin/app/twake/android/chat/FcmPushService.kt

@@ -1,7 +1,8 @@
-package com.twake.twake
+package app.twake.android.chat
+
 import com.famedly.fcm_shared_isolate.FcmSharedIsolateService
 
-import com.twake.twake.MainActivity
+import app.twake.android.chat.MainActivity
 
 import io.flutter.embedding.android.FlutterActivity
 import io.flutter.embedding.engine.FlutterEngine

android/app/src/main/kotlin/com/twake/twake/MainActivity.kt → android/app/src/main/kotlin/app/twake/android/chat/MainActivity.kt

@@ -1,4 +1,4 @@
-package com.twake.twake
+package app.twake.android.chat
 
 import io.flutter.embedding.android.FlutterActivity
 import io.flutter.embedding.engine.FlutterEngine

android/app/src/main/kotlin/com/twake/twake/UnifiedPushService.kt → android/app/src/main/kotlin/app/twake/android/chat/UnifiedPushService.kt

@@ -1,4 +1,4 @@
-package com.twake.twake
+package app.twake.android.chat
 
 import io.flutter.embedding.engine.FlutterEngine
 import io.flutter.embedding.engine.dart.DartExecutor

android/app/src/profile/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.twake.twake">
+    package="app.twake.android.chat">
     <!-- The INTERNET permission is required for development. Specifically,
          the Flutter tool needs it to communicate with the running application
          to allow setting breakpoints, to provide hot reload, etc.

android/fastlane/Appfile

@@ -1,2 +1,2 @@
 json_key_file("keys.json") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
-package_name("com.twake.twake")
+package_name("app.twake.android.chat")

android/fastlane/Fastfile

@@ -36,7 +36,8 @@ platform :android do
   lane :deploy_internal_test do
     track = "internal"
     upload_to_play_store(track: track,
-                         aab: '../build/app/outputs/bundle/release/app-release.aab')
+                         aab: '../build/app/outputs/bundle/release/app-release.aab',
+                         release_status: "draft")
   end
 
   lane :deploy_candidate do

appimage/AppImageBuilder.yml

@@ -8,8 +8,8 @@ version: 1
 AppDir:
   path: ./AppDir
   app_info:
-    id: com.linagora.linux.twake
-    name: Twake
+    id: app.twake.linux.chat
+    name: Twake Chat
     icon: twake
     version: latest
     exec: fluffychat

assets/l10n/intl_en.arb

@@ -2606,8 +2606,6 @@
   "@inactive": {},
   "newGroupChat": "New Group Chat",
   "@newGroupChat": {},
-  "getHelp": "Get help",
-  "@getHelp": {},
   "twakeUsers": "Twake users",
   "@twakeUsers": {},
   "expand": "Expand",
@@ -2952,5 +2950,11 @@
     "placeholders_order": [],
     "placeholders": {}
   },
-  "settingsLanguageDescription": "Set the language you use on Twake Chat"
+  "settingsLanguageDescription": "Set the language you use on Twake Chat",
+  "sendImages": "{count, plural, =1{Send 1 image} other{Send {count} images}}",
+  "enterCaption": "Enter a caption",
+  "failToSend": "Failed to send, please try again",
+  "showLess": "Show Less",
+  "showMore": "Show More",
+  "sharedMediaAndFiles": "Shared media and files"
 }

assets/l10n/intl_fr.arb

@@ -2683,8 +2683,6 @@
   },
   "invite": "Inviter",
   "@invite": {},
-  "getHelp": "Obtenir de l'aide",
-  "@getHelp": {},
   "errorPageTitle": "Il y a un problème",
   "@errorPageTitle": {},
   "forwardTo": "Transmettre à...",

assets/l10n/intl_ru.arb

@@ -2566,8 +2566,6 @@
   "@inactive": {},
   "newGroupChat": "Новый групповой чат",
   "@newGroupChat": {},
-  "getHelp": "Помощь",
-  "@getHelp": {},
   "expand": "Развернуть",
   "@expand": {},
   "shrink": "Свернуть",

assets/l10n/intl_vi.arb

@@ -2733,8 +2733,6 @@
     "type": "text",
     "placeholders": {}
   },
-  "getHelp": "Trợ giúp",
-  "@getHelp": {},
   "pleaseChooseAUsername": "Vui lòng chọn tên đăng nhập",
   "@pleaseChooseAUsername": {
     "type": "text",

docs/adr/0012-improve-ios-notification.md

@@ -0,0 +1,73 @@
+# 12. Improve iOS notification
+
+Date: 2023-12-06
+
+## Status
+
+Accepted
+
+## Context
+The motivation behind this decision is the inability to execute Dart code for decrypting notifications when the iOS app is running in the background. This limitation is different from Android or Web, where Dart code can easily run in such scenarios.
+
+## Decision
+We have decided to make the following changes to address the mentioned issue:
+
+1. **Notification Service Extension (NSE):**
+   - Utilize the [Notification Service Extension](https://developer.apple.com/documentation/usernotifications/modifying_content_in_newly_delivered_notifications) provided by Apple to modify the content of notifications.
+
+2. **MatrixRustSDK Integration:**
+   - Integrate MatrixRustSDK to decrypt messages within the Notification Service Extension. The MatrixRustSDK version and other dependencies should be synchronized with Element X to avoid unexpected errors. Reference the synchronization from [Element X project.yml](https://github.com/vector-im/element-x-ios/blob/main/project.yml#L46).
+
+3. **Automated Script for Source Code Copy:**
+   - Develop a script written in Node.js to automate the process of copying the entire source code related to the Notification Service Extension from Element X, a known version. Detail at [scripts/copy-nse/README.MD](../../scripts/copy-nse/README.MD)
+
+4. **Dart Code Adjustment:**
+   - Modify Dart code to ensure compatibility with the Notification Service Extension from Element X.
+
+5. **Debugging Patch with AppDelegate:**
+   - Add the patch `scripts/patchs/ios-extension-debug.patch` to address debugging issues. This patch removes FlutterAppDelegate and suggests using AppDelegate instead for smoother debugging during Notification Service Extension development.
+
+6. **Add pusher_notification_client_identifier to Default Payload:**
+   - Extend the default notification payload by adding the `pusher_notification_client_identifier` field. This supports multi-account scenarios, where each notification will have a `client_identifier` to identify the user for decryption. For now it is SHA256 of userId
+
+7. **Keychain Access Groups:**
+   - Utilize `keychain-access-groups` to enable data exchange between the Notification Service Extension (NSE) and the main app by using a shared Keychain Access Group. This ensures security and safe data transmission (See details at [link](https://developer.apple.com/documentation/security/keychain_services/keychain_items/sharing_access_to_keychain_items_among_a_collection_of_apps/)).
+
+8. **INSendMessageIntent:**
+   - Use `INSendMessageIntent` to support displaying profile pictures in notifications. Instead of using regular notifications, integrating `INSendMessageIntent` ensures that the sender's image is displayed correctly in the notification (See details at [link](https://stackoverflow.com/questions/68198452/ios-15-communication-notification-picture-not-shown)).
+
+9. **iOS Version Support Below 16:**
+   - Communicate that Element X's Notification Service Extension supports iOS 16 and above. Therefore, Twake NSE will also have a similar requirement. Users with iOS versions below 16 can still install Twake, but they won't be able to decrypt notifications.
+
+## Consequences
+Implementing these decisions has the following consequences:
+
+1. **Notification Discrepancy:**
+   - Notifications will behave differently in the background and foreground because they are handled by Swift in the background and Dart in the foreground.
+
+2. **Integration Challenges:**
+   - There might be challenges in seamlessly integrating Notification Service Extension with MatrixRustSDK and adjusting it to fit the current source code. The MatrixRustSDK version and dependencies should be synchronized with Element X to avoid unexpected errors.
+
+3. **Automated Source Code Copy:**
+   - Introducing an automated Node.js script streamlines the process of copying the source code from Element X, enhancing efficiency and reducing manual errors during this task.
+
+4. **Message Decryption Research:**
+   - Further research is required to successfully decrypt encrypted messages. This introduces a potential risk as it may involve understanding specific nuances when integrating MatrixRustSDK with Notification Service Extension.
+
+5. **Maintenance Overhead:**
+   - Copying source code from Element X may create maintenance overhead, as any updates or changes in Element X's source code need manual integration and synchronization.
+
+6. **Improved Debugging:**
+   - The debugging patch aims to optimize the debugging experience by addressing issues related to FlutterAppDelegate in the context of Notification Service Extension.
+
+7. **Multi-Account Support:**
+   - Multi-account support is achieved by adding `pusher_notification_client_identifier` to the default notification payload.
+
+8. **Security with Keychain Access Groups:**
+   - Ensures secure data transmission between Notification Service Extension and the main app using Keychain Access Groups.
+
+9. **Profile Picture Display Enhancement:**
+   - The use of `INSendMessageIntent` enhances the user experience by ensuring the correct display of sender profile pictures in notifications.
+
+10. **iOS 16 Requirement:**
+    - Communicates that Element X's Notification Service Extension requires iOS 16 or later, and Twake NSE has a similar requirement. Users below iOS 16 can install Twake but won't decrypt notifications.

docs/adr/0012-refactor-message-widget.md

@@ -0,0 +1,23 @@
+# 1. refactor message widget
+
+Date: 2023-06-12
+
+## Status
+
+Accepted
+
+## Context
+
+The Message widget requires refactoring as it currently spans approximately 1000 lines of code, making it challenging to read due to Dart formatting issues and its reliance on a large controller. This widget is intended for reuse in various contexts, such as threads and pinned messages.
+
+## Decision
+
+- Eliminate the dependency on the chat controller entirely in the Message widget.
+- Optimize optional parameters, aiming for minimal usage and preferring child classes when appropriate.
+- If the file exceeds 300 lines of code, create a child widget and relocate it to a separate file.
+- For complex logic, introduce mixins or stateful widgets.
+- Transfer utility methods to extensions or other classes to facilitate reuse.
+
+## Consequences
+
+The Message class is now under 300 lines of code and no longer relies on the controller. Child widgets have been moved to separate files for improved reusability.