TW-1049 Notification improve iOS notification #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drminh2807
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev and
imGok
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1078 |
sherlockvn
reviewed
Nov 30, 2023
hoangdat
reviewed
Nov 30, 2023
hoangdat
reviewed
Nov 30, 2023
hoangdat
reviewed
Nov 30, 2023
hoangdat
reviewed
Nov 30, 2023
hoangdat
reviewed
Nov 30, 2023
lib/utils/matrix_sdk_extensions/flutter_hive_collections_database.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Nov 30, 2023
hoangdat
reviewed
Dec 1, 2023
There was a problem hiding this comment.
can you explain why we need this file
There was a problem hiding this comment.
you cannot debug NSE with FlutterAppDelegate
It retuns that crash
Cannot create a FlutterEngine instance in debug mode without Flutter tooling or Xcode.
To launch in debug mode in iOS 14+, run flutter run from Flutter tools, run from an IDE with a Flutter IDE plugin or run the iOS project from Xcode.
Alternatively profile and release mode apps can be launched from the home screen.
you should remove FlutterAppDelegate and use AppDelegate instead
|
Can you summarize the steps to do this tickets :) because it's hard to review and follow |
please dont review *.swift files, I just copy 100% from Element X |
hoangdat
reviewed
Dec 4, 2023
hoangdat
reviewed
Dec 5, 2023
There was a problem hiding this comment.
actual no need, but I just copy all from Element X, it can make easy when you want copy it again from Element X in the future
hoangdat
reviewed
Dec 5, 2023
hoangdat
reviewed
Dec 5, 2023
hoangdat
reviewed
Dec 5, 2023
hoangdat
reviewed
Dec 5, 2023
hoangdat
reviewed
Dec 7, 2023
hoangdat
reviewed
Dec 7, 2023
hoangdat
reviewed
Dec 7, 2023
hoangdat
reviewed
Dec 7, 2023
hoangdat
approved these changes
Dec 7, 2023
drminh2807
force-pushed
the
TW-1049-Notification-Improve-iOS-notification
branch
from
626f823 to
bbe176b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: Please dont review *.swift files, I just copy 100% from Element X
Issue
Demo
RPReplay_Final1701847387.MP4