Skip to content

Commit

Permalink
fixup! fixup! TW-1781: fix the ci issue
Browse files Browse the repository at this point in the history
  • Loading branch information
sherlockvn committed May 24, 2024
1 parent 90f0476 commit 13de2f6
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/gh-pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ jobs:
flutter config --enable-web
flutter clean
flutter pub get
flutter pub run build_runner build --delete-conflicting-outputs && flutter gen-l10n
flutter pub run build_runner build --delete-conflicting-outputs
flutter pub get
flutter build web --release --verbose --source-maps --base-href="/${GITHUB_REPOSITORY##*/}/$FOLDER/"
echo "$TWAKE_PREVIEW_CONFIG" | yq '.issue_id = strenv(FOLDER)' > ./build/web/config.json
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ jobs:

- name: Run widget test
run: |
flutter pub get && flutter pub run build_runner build --delete-conflicting-outputs && flutter gen-l10n
flutter pub get && flutter pub run build_runner build --delete-conflicting-outputs
flutter pub get
flutter test
# integration_test:
Expand Down
File renamed without changes.
21 changes: 21 additions & 0 deletions docs/adr/0023-upgrade-flutter-3.22.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# 21. Listen to presence status

Date: 2024-05-24

## Status

Accepted

## Context

We need to upgrade the flutter to have up-to-date performance and features

## Decision

- remove `background` and `onBackground` color, now use only `surface` and `onSurface`
- change name from `surfaceVariant` => `surfaceContainerHighest`, `MaterialStateProperty` => `WidgetStateProperty`, `MaterialState` => `WidgetState`, use `super.key` for shorter form (new lint rule)
- Migration from `RawKeyEvent` to `KeyEvent`. [Read more](https://docs.flutter.dev/release/breaking-changes/key-event-migration#deprecated-apis-that-have-an-equivalent) (in conclusion, add ignore_deprecated, because that when i test it again, the up/down not work)
- Upgrade flutter_local_notification from `requestPermission` => `requestNotificationsPermission` [Changelog](https://pub.dev/packages/flutter_local_notifications/changelog#16001), [Readmore](https://developer.android.com/develop/ui/views/notifications/notification-permission?hl=vi)
- Upgrade `url_laucher`, change from `Uri` to `WebUri`, remove `ChromeSafariBrowserSettings` in web
- Upgrade `the index.html` file in web folder
- Upgrade other packages in pubspec.yaml to resolve conflicts
3 changes: 2 additions & 1 deletion scripts/code_analyze.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/sh -ve
flutter pub get && flutter pub run build_runner build --delete-conflicting-outputs && flutter gen-l10n
flutter pub get && flutter pub run build_runner build --delete-conflicting-outputs
dart format --set-exit-if-changed lib/ test/
flutter pub get
flutter analyze

0 comments on commit 13de2f6

Please sign in to comment.