-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
full id service #156
Open
rezk2ll
wants to merge
331
commits into
master
Choose a base branch
from
full-id-rebase
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
full id service #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r better handling of optionnal parameters
…on and achieve sufficient test coverage. Register is still WIP as it needs refactoring to have cleaner code and some features need other endpoints to be implemented first to complete it. Also changed AuthenticationTypes typings but this is temporary.
… room. Fixed the typings of flows and params in the config
… Added a function to convert a localpart string to a matrixId in utils. Refactored the code for registered and finalized whoami to take into account appservice requests.
…message, completed deactivate and added tests for it, modified SafeClientEvent typing
…es from all tables
… before uiauthenticate, changed uiauthenticate to prevent obsolete jsoncontent call, added typecheckers
…ages deletion by batches of 10, finished delete_devices endpoint
…one at all to prevent confusion for others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.