Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added endpoint to reset password #140

Merged
merged 25 commits into from
Aug 16, 2024
Merged

Conversation

BichraiX
Copy link
Collaborator

Added endpoint from the spec : https://spec.matrix.org/v1.11/client-server-api/#post_matrixclientv3accountpassword

Added function to get the access token from the request headers or query to utils package and replaced the associated code in tom-server, identity-service, and client-server.

Added checks for server capabilities to /add, /bind and /delete from spec : https://spec.matrix.org/v1.11/client-server-api/#capabilities-negotiation

const hash = new Hash()
hash.ready
.then(() => {
const hashedPassword = hash.sha256(body.new_password) // TODO : Handle other algorithms

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
})
.catch((e) => {
// istanbul ignore next
console.error('Error while deleting devices and token')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No console, use logger

@BichraiX BichraiX requested a review from guimard August 16, 2024 05:55
@guimard guimard merged commit 4d8b130 into full-id-service Aug 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants