Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

Update dependencies to openzeppelin 4.9.5 #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

backseats
Copy link

@backseats backseats commented Jan 23, 2024

This fixes the issue installing tag 1.1.2 where ERC721OpenZeppelinBase couldn't import import "@openzeppelin/contracts/token/ERC721/ERC721.sol";

Since the repo uses a combination of package.json for the OZ install due to hardhat dependences (I assume) and foundry dependencies (murky) and remappings.txt points to the node_modules version of the OZ contracts, updating to the latest pre-5.0 install seems to be the fix.

Post 5.0 Ownable changes to require an address in the constructor rather than assuming msg.sender so these contracts rely on pre-OZ 5.0

$ forge build
[⠊] Compiling...
Error: 
failed to resolve file: "/Users/backseats/uncanny/lib/openzeppelin-contracts/contract/contracts/token/ERC721/ERC721.sol": No such file or directory (os error 2); check configured remappings.
    --> "/Users/backseats/uncanny/lib/creator-token-contracts/contracts/token/erc721/ERC721OpenZeppelin.sol"
        "@openzeppelin/contracts/token/ERC721/ERC721.sol"

Renders #9 redundant

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant