This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue installing tag 1.1.2 where
ERC721OpenZeppelinBase
couldn't importimport "@openzeppelin/contracts/token/ERC721/ERC721.sol";
Since the repo uses a combination of
package.json
for the OZ install due to hardhat dependences (I assume) and foundry dependencies (murky) andremappings.txt
points to thenode_modules
version of the OZ contracts, updating to the latest pre-5.0 install seems to be the fix.Post 5.0
Ownable
changes to require an address in the constructor rather than assumingmsg.sender
so these contracts rely on pre-OZ 5.0Renders #9 redundant