[TAS-2815] ✨ Implement Christmas campaign #1990
Open
+163
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
added a commit
that referenced
this pull request
Dec 18, 2024
AuroraHuang22
changed the title
AuroraHuang22
changed the title
AuroraHuang22
added a commit
that referenced
this pull request
Dec 18, 2024
nwingt
reviewed
Dec 18, 2024
| export default { | ||
| data() { | ||
| return { | ||
| messages: ['🎄聖誕限時 全店9折優惠', '於付款頁面輸入優惠碼”CHRISTMAS10”'], |
| } catch (error) {} | ||
| }, | ||
| }, | ||
| created() { |
There was a problem hiding this comment.
Please fix lint warning
The "created" property should be above the "methods" property on line 42
src/pages/shopping-cart/book.vue
Outdated
| @@ -352,7 +361,7 @@ export default { | |||
| fbClickId: this.fbClickId, | |||
| items: this.shoppingCartBookItems, | |||
| email: this.walletEmail, | |||
| coupon: this.coupon, | |||
| coupon: this.coupon || 'CHRISTMAS10', | |||
There was a problem hiding this comment.
上面是寫讓人輸入但這裡其實會導致他沒法（沒需要）輸入？會不會引致誤會
| }, | ||
| computed: { | ||
| repeatedMessages() { | ||
| return [...this.messages, ...this.messages]; |
There was a problem hiding this comment.
Suggested change
| return [...this.messages, ...this.messages]; | |
| return this.messages.concat(this.messages); |
Seems less clumsy this way, since ... creates new array
AuroraHuang22
added a commit
that referenced
this pull request
Dec 19, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-12-18.2.23.04.mov