[TAS-2526] 🐛 Fix gifting edition selection #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamchong
approved these changes
Nov 25, 2024
AuroraHuang22
approved these changes
Nov 26, 2024
nwingt
added a commit
that referenced
this pull request
Nov 26, 2024
|
Disable gifting for physical books
|
AuroraHuang22
approved these changes
Nov 26, 2024
williamchong
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1967
selectedValue(bad naming, should nameselectedEditionIndex) instead of a separated component data to prevent data out-syncselectedValueacross the product page & the gift dialog by sharing the same prop@AuroraHuang22 Notice that
update:valueis only available in Vue 3