Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Make author in card clickable #1958

Merged
merged 2 commits into from
Nov 15, 2024
Merged

🚸 Make author in card clickable #1958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfe546c
🚸 Make author in card clickable
williamchong Nov 15, 2024
85c547d
📈 Pass ll_medium in nft card
williamchong Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/components/NFTBook/ItemCardV2.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,36 @@
@click.native="$emit('click-cover', $event)"
/>

<div
<NuxtLink
:to="viewInfoLocation"
class="mt-[8px] text-[#333] text-[1rem] font-[500] laptop:text-[1.125rem]"
>
{{ productName }}
</div>
</NuxtLink>

<div class="text-[#8B8B8B] text-[0.875rem] laptop:text-[1rem]">
{{ (iscnWorkAuthor || creatorDisplayName) | ellipsis }}
<NuxtLink
v-if="iscnWorkAuthor"
:to="
localeLocation({
name: 'store',
query: { q: iscnWorkAuthor },
})
"
>
{{ iscnWorkAuthor | ellipsis }}
</NuxtLink>
<NuxtLink
v-else
:to="
localeLocation({
name: 'id',
params: { id: productOwner },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add ll_medium?

})
"
>
{{ creatorDisplayName | ellipsis }}
</NuxtLink>
</div>

<div class="mt-[16px] text-[#1F1F1F] text-[0.875rem] laptop:text-[1rem]">
Expand Down
4 changes: 3 additions & 1 deletion src/components/SiteHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
:to="
localeLocation({
name: 'store',
ll_medium: 'header_store_button',
query: {
ll_medium: 'header_store_button',
},
})
"
preset="tertiary"
Expand Down Expand Up @@ -351,7 +353,7 @@
);
await this.connectWallet();
} catch (err) {
console.error(err);

Check warning on line 356 in src/components/SiteHeader.vue

View workflow job for this annotation

GitHub Actions / CI 

Unexpected console statement
this.alertPromptError(err);
} finally {
this.isLoggingIn = false;
Expand Down
3 changes: 3 additions & 0 deletions src/pages/gutenberg/free-audio-books.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,9 @@ export default {
this.$router.push(
this.localeLocation({
name: 'store',
query: {
ll_medium: 'gutenberg',
},
})
);
},
Expand Down
Loading