Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title automatically from url #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codegod100
Copy link

Description

Hey! We may have been a bit over zealous with requesting discussions before every PR, we don't want to stifle people that just want to contribute! If you'd like to open all these again we'd be happy to look over them. I've put a rudimentary PR template in place for the time being.

This adds title automatically from url

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran locally on system

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atproto-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:25pm
frontpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:25pm
unravel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:25pm

@codegod100 codegod100 marked this pull request as draft October 28, 2024 18:17
@codegod100
Copy link
Author

codegod100 commented Oct 28, 2024

Converting to draft since I found "cardyb" service from bsky which allows us to do this from frontend e.g. https://cardyb.bsky.app/v1/extract?url=https%3A%2F%2Fgoogle.com

Copy link

vercel bot commented Oct 28, 2024

@codegod100 is attempting to deploy a commit to the Scribe Team on Vercel.

A member of the Team first needs to authorize it.

@will-corrigan
Copy link

This seems to only work if you copy and paste a url and gives 500 responses/crashes the app if you start typing. At least on the preview branch.

I'll have to think about the user experience of this and whether a user would prefer an option to use the title or not but it might get annoying for some people to auto populate a title they don't want every time.

@codegod100
Copy link
Author

Ah yeah I didn't test that use case. All my entries have been copy paste urls. I personally really dislike manually entering a title if one already exists 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants