Ensure handles are treated as case insensitive when signing in #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tom-sherman
commented
Sep 23, 2024
| @@ -14,6 +14,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@atproto/oauth-types": "^0.1.2", | |||
| "@atproto/syntax": "^0.3.0", | |||
There was a problem hiding this comment.
The @atprotoification of our code begins lol.
I'm gonna gradually convert our handling of core protocol things (handles, DIDs, did doc and pds resolution etc.) to the official libraries but definitely still don't wanna use the API clients because they're not really suited to our use case.
damiensedgwick
previously approved these changes
Sep 24, 2024
| let handleOrDid = identifier; | ||
| // Sanitize only handles | ||
| if ( | ||
| isValidHandle(identifier) || |
There was a problem hiding this comment.
we need to strip whitespace too
are handles case sensitive or just want lowercase?
There was a problem hiding this comment.
Handles are case insensitive (like domain names) but dids are technical case sensitive.
tom-sherman
dismissed stale reviews from JakeSaterlay and damiensedgwick
via
35c4c98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.