Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth #114

Merged
merged 66 commits into from
Sep 22, 2024
Merged

OAuth #114

merged 66 commits into from
Sep 22, 2024

Conversation

tom-sherman
Copy link
Contributor

@tom-sherman tom-sherman commented Aug 17, 2024 •
edited
Loading

Test plan

Basically just get a bunch of folks to try it out... especially with folks that have did:web or self hosted PDSes. I'd also like to get this reviewd by the atproto team, pretty sure this is the first 3rd party implementation of atproto oauth.

Todo

@tom-sherman
Implement up until par request
b32f709
@tom-sherman
Patch oauth4webapi so it doesn't send charset in header
5a97ea6 
See bluesky-social/atproto#2717
@tom-sherman
Fix appUrl logic 🤦‍♂️
a28f8b5
@tom-sherman
Remove unused code
d119218
@tom-sherman
Client ID needs to be the client-metadata URL
d7a98b5
@tom-sherman
Parse par result and redirect
dfd2942
@tom-sherman
Rename to getClientMetadata
858f837
@tom-sherman
Remove unused zod
2acb905
@tom-sherman
Fix type errors
0236fa1
@tom-sherman
Add extra logging
0427b02
@tom-sherman
Log client metadata
36fbb14
@tom-sherman
Ensure appUrl has https
4191ae4
@tom-sherman
Use VERCEL_BRANCH_URL in preview
8c603cd
@tom-sherman
App passwords ➡️🗑️
5dda1ae
@tom-sherman
Add OAuth requests to database
334f02b
@tom-sherman
Use handlers API from next-auth
71e0fb5
@tom-sherman
Disable button while signing in
3ca31ed
@tom-sherman
Generate unique jwk for oauth request
61403e0
@tom-sherman
Add public jwk
53a2b5e
@tom-sherman
Patch pushedAuthorizationRequest to add dpop expiry
a3d63ef 
Commented out because it fails on a missing nonce error now
@tom-sherman
We need to do PAR twice so that we can get an initial dpop nonce
228ce72
@tom-sherman
Format
dd97f38
@tom-sherman
Fix form pending state
76c8422
@tom-sherman
Implement callback
e7356a7
@tom-sherman
Login and logout should now work
347141e
@tom-sherman
Login/logout
80e2498
@linear Linear
Copy link

linear bot commented Aug 17, 2024

UN-73 OAuth login

@vercel Vercel
Copy link

vercel bot commented Aug 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 7:59pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
atproto-browser ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 7:59pm
unravel ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 7:59pm

@timothyis timothyis self-requested a review September 22, 2024 19:53
timothyis
timothyis previously approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@timothyis timothyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@WillCorrigan
Copy link
Collaborator

welcome to the future

@tom-sherman tom-sherman merged commit 77b9e4f into main Sep 22, 2024
5 checks passed
@tom-sherman tom-sherman deleted the tom/un-73-oauth-login branch September 22, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillCorrigan WillCorrigan WillCorrigan approved these changes

@timothyis timothyis timothyis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-sherman @WillCorrigan @timothyis