Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc warnings #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrelfpinto
Copy link

@lihaoyi, I have made some PRs. I decided not to do a single one because they are somewhat unrelated and this way you can them approve (or not) independently. If you prefer a single one, just say it.

@lihaoyi
Copy link
Owner

lihaoyi commented Nov 9, 2016

Sorry I have been unresponsive, got two Scala by the Bay events coming up I
need to prepare for and still getting the last sets of libraries out for
Scala 2.12. Realistically won't be able to look at these for another week,
but I will look at them. Thanks for your patience!

On Wed, Nov 9, 2016 at 9:33 AM, André L. F. Pinto [email protected]
wrote:

@lihaoyi https://github.com/lihaoyi, I have made some PRs. I decided
not to do a single one because they are somewhat unrelated and this way you
can them approve (or not) independently. If you prefer a single one, just

say it.

You can view, comment on, or merge this pull request online at:

#37
Commit Summary

  • Remove unused variables
  • Fix discarded non-Unit value

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#37, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5A_BEfHtCOZl-KynxyARsIf9Grkfs7ks5q8SLPgaJpZM4KtGo3
.

@andrelfpinto
Copy link
Author

That's ok. I hope you don't mind if I keep pushing PRs. Best luck with your events!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants