Fix itest re new behaviors introduced by blockbeat
#9368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
added
code health
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Pull reviewers statsStats of the last 30 days for lnd:
|
yyforyongyu
force-pushed
the
yy-blockbeat-itest
branch
from
7f36d5e to
197ab3f
Compare
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
from
bde86dc to
8e08948
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-itest
branch
from
197ab3f to
198635d
Compare
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
4 times, most recently
from
9d5e14b to
5070e58
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-itest
branch
from
198635d to
89c1f0d
Compare
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
2 times, most recently
from
0c58fd4 to
96756b4
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-itest
branch
from
89c1f0d to
5851746
Compare
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
from
96756b4 to
9d62968
Compare
yyforyongyu
force-pushed
the
yy-blockbeat-itest
branch
from
5851746 to
b4ab36c
Compare
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
from
9d62968 to
d259917
Compare
yyforyongyu
changed the base branch from
yy-blockbeat-itest
to
yy-feature-blockbeat
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
from
d259917 to
4430487
Compare
|
linter failed due to "no space left" |
yyforyongyu
force-pushed
the
yy-feature-blockbeat
branch
2 times, most recently
from
f39caff to
ecd82a3
Compare
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
from
4430487 to
e885bf5
Compare
This commit adds a new flag to shuffle all the test cases before running them so tests which require lots of blocks to be mined are less likely to be run in the same tranch. The other benefit is this approach provides a more efficient way to figure which tests are broken since all the differnet backends are running different tranches in their builds, we can identify more failed tests in one push.
Also removed the duplicate test cases.
Also fixes a wrong usage of `ht.Subtest`.
To make the CI indicative, we now starting tracking the flaky tests found when running on Windows. As a starting point, rather than ignore the windows CI entirely, we now identify there are cases where lnd can be buggy when running in windows. We should fix the tests in the future, otherwise the windows build should be deleted.
To increase the speed from 40m per run to roughly 20m per run.
Most of the time we only need to fund the node with given number of UTXOs without concerning the amount, so we add the more efficient funding method as it mines a single block in the end.
Previous splitting logic simply put all the remainder in the last tranche, which could make the last tranche run significantly more test cases. We now change it so the remainder is evened out across tranches.
For Windows the tests run much slower so we create customized timeouts for them.
This commit removes the panic used in checking the shutdown log. Instead, the error is returned and asserted in `shutdownAllNodes` so it's easier to check which node failed in which test. We also catch all the errors returned from `StopDaemon` call to properly access the shutdown behavior.
Keep the SQL, etcd, bitcoin rpcpolling builds and non-ubuntu builds at 8 since they are less stable.
We sometimes see `timeout waiting for UTXOs` error from bitcoind-related itests due to the chain backend not synced to the miner. We now assert it's synced before continue.
The response from `ClosedChannels` may not be up-to-date, so we wrap it inside a wait closure.
yyforyongyu
force-pushed
the
yy-waiting-on-merge
branch
from
e885bf5 to
2913f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the branch that will be merged to master once the following PRs are merged,
This series fix all the itest flakes to make sure the blockbeat works as expected. Check #9306 for more context, and #9260 for the final results and improvements.
Depends on
blockbeat#9315