Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: create branch for v0.18.4-beta #9367

Merged
merged 3 commits into from
Dec 17, 2024
Merged

release: create branch for v0.18.4-beta #9367

merged 3 commits into from
Dec 17, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Dec 16, 2024

Preparation PR to kick off the v0.18.4-beta.rc3 release.

This PR includes rebased versions of the following PRs (in order):

GeorgeTsagk and others added 2 commits December 16, 2024 12:51
@GeorgeTsagk @guggero
contractcourt: include custom records on replayed htlc
d30cba1 
When notifying the invoice registry for an exit hop htlc we also want to
include its custom records. The channelLink, the other caller of this
method, already populates this field. So we make sure the contest
resolver does so too.
@guggero
Merge branch '0-18-4-branch-rc3-9357' into 0-18-4-branch-rc3
88cbec2
@guggero guggero added golang/build system Related to the go language and compiler releases no-changelog labels Dec 16, 2024
@guggero guggero added this to the v0.18.4 milestone Dec 16, 2024
@guggero guggero self-assigned this Dec 16, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for lnd:

User Total reviews Time to review Total comments
guggero
🥇		 30
▀▀▀		 1d 3h 43m
 35
▀
yyforyongyu
🥈		 12
▀		 1d 10h 44m
 11
ziggie1984
🥉		 12
▀		 17d 6h 17m
▀▀▀▀		 92
▀▀▀
bhandras
 11
▀		 1d 21h 45m
 26
▀
Roasbeef
 10
▀		 5d 12h 51m
▀		 50
▀▀
ellemouton
 10
▀		 21h 21m
 27
▀
starius
 3
 2d 1h 5m
▀		 12
bitromortac
 3
 7d 44m
▀▀		 26
▀
Abdulkbk
 3
 13h 37m
 2
djkazic
 1
 1d 11h 22m
 1
ProofOfKeags
 1
 9m
 0
GeorgeTsagk
 1
 23h 29m
 2
saubyk
 1
 6h 36m
 0
baldbull69
 1
 2h 12m
 1

@yyforyongyu
Copy link
Member

hmm weird the linter failed

@guggero
Copy link
Collaborator Author

guggero commented Dec 17, 2024

hmm weird the linter failed

Yeah, we don't have all the rule updates in this branch, so it's kind of expected.

@guggero guggero changed the title release: create branch for v0.18.4-beta.rc3 release: create branch for v0.18.4-beta Dec 17, 2024
@guggero guggero merged commit ddeb835 into 0-18-4-branch Dec 17, 2024
19 of 27 checks passed
@guggero guggero deleted the 0-18-4-branch-rc3 branch December 17, 2024 20:17
@yyforyongyu yyforyongyu mentioned this pull request Dec 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

@yyforyongyu yyforyongyu yyforyongyu approved these changes

Assignees

@guggero guggero

Labels
golang/build system Related to the go language and compiler no-changelog releases
Projects
None yet
Milestone
v0.18.4
Development

Successfully merging this pull request may close these issues.
3 participants
@guggero @yyforyongyu @GeorgeTsagk