tapdb: Federation DB fixes #583
Conversation
|
After offline discussion, new plan is to actually not change the table here but instead just update the queries to insert a default values of all 0's when the underlying type is We can also add a migration to DROP any contents in this table. Since no deployment should have a local Universe config set, including the Universe servers we run, this should not be an issue. |
|
Needs a rebase.
I think this could work. Drop the old, then add on new. |
jharveyb
force-pushed
the
federation_db_fixes
branch
from
80e57a6 to
ce52b05
Compare
jharveyb
force-pushed
the
federation_db_fixes
branch
from
ce52b05 to
67a41c2
Compare
|
Verified locally on mainnet setup with the original issue that old local configs were dropped and upsert now works via CLI. |
jharveyb
force-pushed
the
federation_db_fixes
branch
from
67a41c2 to
2ae9f61
Compare
In this commit, we fix an issue with universe sync config storage. With the old table schema, multiples entries could exist for the same Universe because the UNIQUE constraint did not function as intended. This was caused by NULL entries being treated as unique values vs. one value. The new table has one entry per Universe ID, which fixes this.
jharveyb
force-pushed
the
federation_db_fixes
branch
from
2ae9f61 to
4ed7bfe
Compare
Fixes multiple issues with sync config load and store.
The first issue was the federation DB handle not returning the correct global config when the global config is modified for one proof type - this is resolved by loading the default config, and keying configs by proof type. Configs read from the DB then replace the default config with the matching proof type.
The second issue affected grouped assets, and led to group member asset IDs not being shown on the CLI.
The third issue was the UNIQUE constraint on universe sync configs not being enforced, since NULL values are distinct in UNIQUE constraints by default for SQLite and Postgres. This could lead to a bad configuration state with multiple entries for the same universe. This behavior is not configurable for SQLite, so extra columns were added that have a default value when one field of the universe ID is NULL. This should fix the DB constraint.