asset: update parsing to return error if unknown odd type encountered #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, as a follow up to the recent even/odd type split, we add some helper functions to assert that when we decode an asset TLV stream, we bail out if we find any unknown types.
Roasbeef
commented
Oct 10, 2023
| @@ -30,6 +34,71 @@ const ( | |||
| LeafAssetID LeafTlvType = 11 | |||
| ) | |||
|
|
|||
| // KnownAssetLeafTypes is a set of all known leaf types. | |||
| var KnownAssetLeafTypes = fn.NewSet( | |||
There was a problem hiding this comment.
Ideally we can set up some compile or init level thing to make sure that each time the set of types are updated, then this is as well.
guggero
approved these changes
Nov 27, 2023
|
|
||
| // Erorr returns the error message for the ErrUnknownType. | ||
| func (e ErrUnknownType) Error() string { | ||
| return fmt.Errorf("unknown type %d", e.UnknownType).Error() |
There was a problem hiding this comment.
nit: why not just fmt.Sprintf()?
jharveyb
approved these changes
Dec 8, 2023
jharveyb
reviewed
Dec 8, 2023
| } | ||
|
|
||
| for _, testCase := range testCases { | ||
|
|
There was a problem hiding this comment.
linter fail on this extra newline.
|
!lightninglabs-deploy mute 720h00m |
|
!lightninglabs-deploy mute 720h00m |
|
@Roasbeef, remember to re-request review from reviewers when ready |
|
!lightninglabs-deploy mute 336h00m |
|
Replaced by #1037. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, as a follow up to the recent even/odd type split, we add some helper functions to assert that when we decode an asset TLV stream, we bail out if we find any unknown types.