Generalise universe structs/methods/variables to support transfer proofs in addition to issuance proofs #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
force-pushed
the
rename-universe-structs-methods
branch
from
cda6575 to
d387a3f
Compare
Roasbeef
requested changes
Sep 26, 2023
ffranr
force-pushed
the
rename-universe-structs-methods
branch
from
d387a3f to
151cafc
Compare
guggero
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we change instances of "minting", "base", and "issuance" to more general terminology which will clarify that the code is also used for transition proofs (non-issuance).
Associated issue: #535
I may create additional PRs so I don't necessarily want this PR to close the above issue.