tapdb: fix time zone issue with timestamps #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM 🦚
Only request is some additional detail in the commit message body:
- Why did the comparison of the UTC vs localized timestamps encounter an issue here?
- Why didn't the db translation layer handle normalizing the timestamps?
- For all the other areas we use timestamps, do we always need to map them to UTC before inserting?
| @@ -1682,7 +1682,7 @@ func (a *AssetStore) LeaseCoins(ctx context.Context, leaseOwner [32]byte, | |||
| err = q.UpdateUTXOLease(ctx, UpdateUTXOLease{ | |||
| LeaseOwner: leaseOwner[:], | |||
| LeaseExpiry: sql.NullTime{ | |||
| Time: expiry, | |||
| Time: expiry.UTC(), | |||
There was a problem hiding this comment.
👍 for doing this at the lowest level.
Because sqlc by default just uses the time.Time.String() method to turn a timestamp into the DB value, the time zone of the timestamp has an impact as any SQL query would basically be a string comparison that doesn't look at the time zone at all. For example: WHERE a < b Would be true for a = '2023-09-26 14:00:00 GMT-8' (22:00 local time) a = '2023-09-26 15:00:00 UTC' (15:00 local time) Even though 10pm is clearly after 3pm. To fix this, we explicitly call .UTC() on any time.Time we use in any SQL query. The only instances where that was not yet the case in the whole tapdb package were the newly added queries for UTXO leases. It seems that with a later release of the sqlite driver we could customize this behavior of how a timestamp is being formatted. But for now the .UTC() workaround should work as well.
guggero
force-pushed
the
fix-lease-timestamp-utc
branch
from
c8ba4a1 to
05e8ae1
Compare
|
Added a commit message to clarify on this. It looks like we could customize this by setting |
jharveyb
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where unit tests would fail when being run in certain time zones.