Backoff procedure erroneously resumed between two different send events #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2023
guggero
approved these changes
Sep 25, 2023
This change ensures that the locator contains different values between two different send events which re-use the same Taproot Asset address.
ffranr
force-pushed
the
backoff-multi-send-bug
branch
from
ee11ac8 to
30b333d
Compare
guggero
reviewed
Sep 25, 2023
| @@ -74,8 +75,16 @@ func (l *Locator) Hash() [32]byte { | |||
| } | |||
| buf.Write(l.ScriptKey.SerializeCompressed()) | |||
|
|
|||
| if l.OutPoint != nil { | |||
| err := lnwire.WriteOutPoint(&buf, *l.OutPoint) | |||
There was a problem hiding this comment.
Ah, forgot about the error return type. Since we ignore any errors returned by buf.Write() above (which AFAIK can never return an actual error on a bytes.Buffer but is part of the io.Writer interface anyway), we probably can do the same here as well.
There was a problem hiding this comment.
The was merged before I saw your comment! Let me know if you want me to open another PR to go back on the err handling (I'm guessing this is fine as is?).
There was a problem hiding this comment.
Yeah, no problem, let's leave it the way it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #508
This PR fixes the initial state of the proof courier's backoff procedure. Before this change, the initial state of the backoff procedure would erroneously include the previous send event(s). The fix involves using the outpoint to distinguish between send events.