Generalise multiverse method names to support all proofs. #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are more changes to make along the same lines, but we might as well get these in. |
jharveyb
approved these changes
Sep 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I think this might need a rebase to get the CI/merge queue passing. |
ffranr
force-pushed
the
multiverse-rename
branch
from
ae4ce24 to
682f905
Compare
ffranr
force-pushed
the
multiverse-rename
branch
from
682f905 to
e7beb2f
Compare
|
Not sure why, but the postgres itest keeps failing consistently... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames multiverse store and archive method names to reflect the fact that they are now handle transfer proofs in addition to issuance proofs.
We should merge #473 first.