-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain porter proof courier service initialised using configurable address #459
Conversation
Having spoken with @guggero , I'm going to modify this PR as follows: The goal is for the proof courier address to survive the chain porter send package log/resume cycle so that it is available when constructing the proof courier service handle. To accomplish that, instead of adding the proof courier address as a new field in the asset transfer table, I will add a new addr field to vPSBT outputs and corresponding db table. |
Just to clarify: my intention was to store the full, serialized tap-address in the vPSBT and transfer_output_table, not just the proof courier address. that way we get ourselves some future proofing if we ever add another attribute to a tap-address, then don't need yet another field in vPSBT/transfer-output. |
Or we just also store the full address as well which may be useful for record keeping purposes?
Why's it need to be the vPBST vs just a new column in the row? |
3c26ba3
to
ee66887
Compare
Following a call with @Roasbeef , this is the latest direction for this PR: Where the chain porter is concerned, we no longer add the This PR also includes changes to the custodian, which now instantiates a proof courier service using the address that we lookup in our address book. This PR also changes the I think the following test breaks between 00:00 and 01:00 https://github.com/lightninglabs/taproot-assets/blob/fad3d845f68ec7fa09eb0c05f5f9c7455358928e/tapdb/universe_stats_test.go#L201C42-L201C42 This PR doesn't include a new This PR should now also close #462 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress on this! Everything around the proof courier interfaces and delivery looks great. Though I don't think we can get away without storing the address in the vPSBT as well (see inline comment) for the full vPSBT interactive cases.
99763e6
to
7a6f08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending @Roasbeef's comments.
7a6f08c
to
0be6f9d
Compare
0be6f9d
to
9d2cd98
Compare
Instead of specifying a TLS certificate file path, we now skip TLS certificate verification whilst dialing into the proof courier service.
9d2cd98
to
e5ef9bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏄🏾
This PR includes changes which allow us to persist a proof courier address for use in resuming a pending package's send process.
Fixes #446